* [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
@ 2017-09-04 15:28 Yuval Shaia
[not found] ` <20170904152848.3471-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Yuval Shaia @ 2017-09-04 15:28 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
swise-ut6Up61K2wZBDgjK7y7TUQ,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
No reason to have dependency on PCI for the entire infiniband stack so
move it to KConfig of only the drivers that actually using PCI.
Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
v0 -> v1:
* As suggested by Thomas Bogendoerfer:
* Remove unneeded header inclusion from ipoib
* Remove PCI dependency from ipoib's Kconfig
---
drivers/infiniband/Kconfig | 1 -
drivers/infiniband/hw/cxgb3/Kconfig | 1 +
drivers/infiniband/hw/cxgb4/Kconfig | 1 +
drivers/infiniband/hw/hfi1/Kconfig | 1 +
drivers/infiniband/hw/i40iw/Kconfig | 1 +
drivers/infiniband/hw/qedr/Kconfig | 1 +
drivers/infiniband/hw/qib/Kconfig | 1 +
drivers/infiniband/sw/rdmavt/Kconfig | 1 +
drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
9 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 234fe01904e7..568088a9298c 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -1,6 +1,5 @@
menuconfig INFINIBAND
tristate "InfiniBand support"
- depends on PCI || BROKEN
depends on HAS_IOMEM
depends on NET
depends on INET
diff --git a/drivers/infiniband/hw/cxgb3/Kconfig b/drivers/infiniband/hw/cxgb3/Kconfig
index 2b6352b85485..bd32926afa77 100644
--- a/drivers/infiniband/hw/cxgb3/Kconfig
+++ b/drivers/infiniband/hw/cxgb3/Kconfig
@@ -1,5 +1,6 @@
config INFINIBAND_CXGB3
tristate "Chelsio RDMA Driver"
+ depends on PCI || BROKEN
depends on CHELSIO_T3 && INET
select GENERIC_ALLOCATOR
---help---
diff --git a/drivers/infiniband/hw/cxgb4/Kconfig b/drivers/infiniband/hw/cxgb4/Kconfig
index afe8b28e0878..7910fdd88619 100644
--- a/drivers/infiniband/hw/cxgb4/Kconfig
+++ b/drivers/infiniband/hw/cxgb4/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_CXGB4
tristate "Chelsio T4/T5 RDMA Driver"
depends on CHELSIO_T4 && INET && (IPV6 || IPV6=n)
+ depends on PCI || BROKEN
select CHELSIO_LIB
select GENERIC_ALLOCATOR
---help---
diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
index f6ea0881765a..5072d083f53b 100644
--- a/drivers/infiniband/hw/hfi1/Kconfig
+++ b/drivers/infiniband/hw/hfi1/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_HFI1
tristate "Intel OPA Gen1 support"
depends on X86_64 && INFINIBAND_RDMAVT && I2C
+ depends on PCI || BROKEN
select MMU_NOTIFIER
select CRC32
select I2C_ALGOBIT
diff --git a/drivers/infiniband/hw/i40iw/Kconfig b/drivers/infiniband/hw/i40iw/Kconfig
index 6e7d27a14061..9cfef1370445 100644
--- a/drivers/infiniband/hw/i40iw/Kconfig
+++ b/drivers/infiniband/hw/i40iw/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_I40IW
tristate "Intel(R) Ethernet X722 iWARP Driver"
depends on INET && I40E
+ depends on PCI || BROKEN
select GENERIC_ALLOCATOR
---help---
Intel(R) Ethernet X722 iWARP Driver
diff --git a/drivers/infiniband/hw/qedr/Kconfig b/drivers/infiniband/hw/qedr/Kconfig
index 6c9f3923e838..8db2966f52c2 100644
--- a/drivers/infiniband/hw/qedr/Kconfig
+++ b/drivers/infiniband/hw/qedr/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_QEDR
tristate "QLogic RoCE driver"
depends on 64BIT && QEDE
+ depends on PCI || BROKEN
select QED_LL2
select QED_RDMA
---help---
diff --git a/drivers/infiniband/hw/qib/Kconfig b/drivers/infiniband/hw/qib/Kconfig
index e0fdb9201423..522a6fcaa9d8 100644
--- a/drivers/infiniband/hw/qib/Kconfig
+++ b/drivers/infiniband/hw/qib/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_QIB
tristate "Intel PCIe HCA support"
depends on 64BIT && INFINIBAND_RDMAVT
+ depends on PCI || BROKEN
---help---
This is a low-level driver for Intel PCIe QLE InfiniBand host
channel adapters. This driver does not support the Intel
diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
index fdd001ce13d8..605bfb1da9df 100644
--- a/drivers/infiniband/sw/rdmavt/Kconfig
+++ b/drivers/infiniband/sw/rdmavt/Kconfig
@@ -1,6 +1,7 @@
config INFINIBAND_RDMAVT
tristate "RDMA verbs transport library"
depends on 64BIT
+ depends on PCI || BROKEN
select DMA_VIRT_OPS
---help---
This is a common software verbs provider for RDMA networks.
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 6c77df34869d..3fc3b7b20297 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -51,7 +51,6 @@
#include <net/addrconf.h>
#include <linux/inetdevice.h>
#include <rdma/ib_cache.h>
-#include <linux/pci.h>
#define DRV_VERSION "1.0.0"
--
2.13.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <20170904152848.3471-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2017-09-04 15:48 ` Jack Wang
[not found] ` <CAD+HZHVH7dUeQ0ibCWNZHgdO-1zh1KGT4C+9h09TiOHx=1Fddw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-05 4:08 ` Leon Romanovsky
1 sibling, 1 reply; 8+ messages in thread
From: Jack Wang @ 2017-09-04 15:48 UTC (permalink / raw)
To: Yuval Shaia
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock,
swise-ut6Up61K2wZBDgjK7y7TUQ,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
2017-09-04 17:28 GMT+02:00 Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>:
> No reason to have dependency on PCI for the entire infiniband stack so
> move it to KConfig of only the drivers that actually using PCI.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> v0 -> v1:
> * As suggested by Thomas Bogendoerfer:
> * Remove unneeded header inclusion from ipoib
> * Remove PCI dependency from ipoib's Kconfig
> ---
> drivers/infiniband/Kconfig | 1 -
> drivers/infiniband/hw/cxgb3/Kconfig | 1 +
> drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> drivers/infiniband/hw/hfi1/Kconfig | 1 +
> drivers/infiniband/hw/i40iw/Kconfig | 1 +
> drivers/infiniband/hw/qedr/Kconfig | 1 +
> drivers/infiniband/hw/qib/Kconfig | 1 +
> drivers/infiniband/sw/rdmavt/Kconfig | 1 +
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
> 9 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 234fe01904e7..568088a9298c 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,5 @@
> menuconfig INFINIBAND
> tristate "InfiniBand support"
> - depends on PCI || BROKEN
> depends on HAS_IOMEM
> depends on NET
> depends on INET
> diff --git a/drivers/infiniband/hw/cxgb3/Kconfig b/drivers/infiniband/hw/cxgb3/Kconfig
> index 2b6352b85485..bd32926afa77 100644
> --- a/drivers/infiniband/hw/cxgb3/Kconfig
> +++ b/drivers/infiniband/hw/cxgb3/Kconfig
> @@ -1,5 +1,6 @@
> config INFINIBAND_CXGB3
> tristate "Chelsio RDMA Driver"
> + depends on PCI || BROKEN
> depends on CHELSIO_T3 && INET
> select GENERIC_ALLOCATOR
> ---help---
> diff --git a/drivers/infiniband/hw/cxgb4/Kconfig b/drivers/infiniband/hw/cxgb4/Kconfig
> index afe8b28e0878..7910fdd88619 100644
> --- a/drivers/infiniband/hw/cxgb4/Kconfig
> +++ b/drivers/infiniband/hw/cxgb4/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_CXGB4
> tristate "Chelsio T4/T5 RDMA Driver"
> depends on CHELSIO_T4 && INET && (IPV6 || IPV6=n)
> + depends on PCI || BROKEN
> select CHELSIO_LIB
> select GENERIC_ALLOCATOR
> ---help---
> diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
> index f6ea0881765a..5072d083f53b 100644
> --- a/drivers/infiniband/hw/hfi1/Kconfig
> +++ b/drivers/infiniband/hw/hfi1/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_HFI1
> tristate "Intel OPA Gen1 support"
> depends on X86_64 && INFINIBAND_RDMAVT && I2C
> + depends on PCI || BROKEN
> select MMU_NOTIFIER
> select CRC32
> select I2C_ALGOBIT
> diff --git a/drivers/infiniband/hw/i40iw/Kconfig b/drivers/infiniband/hw/i40iw/Kconfig
> index 6e7d27a14061..9cfef1370445 100644
> --- a/drivers/infiniband/hw/i40iw/Kconfig
> +++ b/drivers/infiniband/hw/i40iw/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_I40IW
> tristate "Intel(R) Ethernet X722 iWARP Driver"
> depends on INET && I40E
> + depends on PCI || BROKEN
> select GENERIC_ALLOCATOR
> ---help---
> Intel(R) Ethernet X722 iWARP Driver
> diff --git a/drivers/infiniband/hw/qedr/Kconfig b/drivers/infiniband/hw/qedr/Kconfig
> index 6c9f3923e838..8db2966f52c2 100644
> --- a/drivers/infiniband/hw/qedr/Kconfig
> +++ b/drivers/infiniband/hw/qedr/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_QEDR
> tristate "QLogic RoCE driver"
> depends on 64BIT && QEDE
> + depends on PCI || BROKEN
> select QED_LL2
> select QED_RDMA
> ---help---
> diff --git a/drivers/infiniband/hw/qib/Kconfig b/drivers/infiniband/hw/qib/Kconfig
> index e0fdb9201423..522a6fcaa9d8 100644
> --- a/drivers/infiniband/hw/qib/Kconfig
> +++ b/drivers/infiniband/hw/qib/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_QIB
> tristate "Intel PCIe HCA support"
> depends on 64BIT && INFINIBAND_RDMAVT
> + depends on PCI || BROKEN
> ---help---
> This is a low-level driver for Intel PCIe QLE InfiniBand host
> channel adapters. This driver does not support the Intel
> diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
> index fdd001ce13d8..605bfb1da9df 100644
> --- a/drivers/infiniband/sw/rdmavt/Kconfig
> +++ b/drivers/infiniband/sw/rdmavt/Kconfig
> @@ -1,6 +1,7 @@
> config INFINIBAND_RDMAVT
> tristate "RDMA verbs transport library"
> depends on 64BIT
> + depends on PCI || BROKEN
> select DMA_VIRT_OPS
> ---help---
> This is a common software verbs provider for RDMA networks.
does the RDMAVT really depends on PCI, to me looks not, we can also
remove the included in drivers/infiniband/sw/rdmavt/vt.h?
Other than this, I think the change make sense to me!
Cheers,
Jack
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 6c77df34869d..3fc3b7b20297 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -51,7 +51,6 @@
> #include <net/addrconf.h>
> #include <linux/inetdevice.h>
> #include <rdma/ib_cache.h>
> -#include <linux/pci.h>
>
> #define DRV_VERSION "1.0.0"
>
> --
> 2.13.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <CAD+HZHVH7dUeQ0ibCWNZHgdO-1zh1KGT4C+9h09TiOHx=1Fddw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2017-09-04 18:24 ` Yuval Shaia
0 siblings, 0 replies; 8+ messages in thread
From: Yuval Shaia @ 2017-09-04 18:24 UTC (permalink / raw)
To: Jack Wang
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock,
swise-ut6Up61K2wZBDgjK7y7TUQ,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Mon, Sep 04, 2017 at 05:48:29PM +0200, Jack Wang wrote:
> 2017-09-04 17:28 GMT+02:00 Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>:
> > No reason to have dependency on PCI for the entire infiniband stack so
> > move it to KConfig of only the drivers that actually using PCI.
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > v0 -> v1:
> > * As suggested by Thomas Bogendoerfer:
> > * Remove unneeded header inclusion from ipoib
> > * Remove PCI dependency from ipoib's Kconfig
> > ---
> > drivers/infiniband/Kconfig | 1 -
> > drivers/infiniband/hw/cxgb3/Kconfig | 1 +
> > drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> > drivers/infiniband/hw/hfi1/Kconfig | 1 +
> > drivers/infiniband/hw/i40iw/Kconfig | 1 +
> > drivers/infiniband/hw/qedr/Kconfig | 1 +
> > drivers/infiniband/hw/qib/Kconfig | 1 +
> > drivers/infiniband/sw/rdmavt/Kconfig | 1 +
> > drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
> > 9 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> > index 234fe01904e7..568088a9298c 100644
> > --- a/drivers/infiniband/Kconfig
> > +++ b/drivers/infiniband/Kconfig
> > @@ -1,6 +1,5 @@
> > menuconfig INFINIBAND
> > tristate "InfiniBand support"
> > - depends on PCI || BROKEN
> > depends on HAS_IOMEM
> > depends on NET
> > depends on INET
> > diff --git a/drivers/infiniband/hw/cxgb3/Kconfig b/drivers/infiniband/hw/cxgb3/Kconfig
> > index 2b6352b85485..bd32926afa77 100644
> > --- a/drivers/infiniband/hw/cxgb3/Kconfig
> > +++ b/drivers/infiniband/hw/cxgb3/Kconfig
> > @@ -1,5 +1,6 @@
> > config INFINIBAND_CXGB3
> > tristate "Chelsio RDMA Driver"
> > + depends on PCI || BROKEN
> > depends on CHELSIO_T3 && INET
> > select GENERIC_ALLOCATOR
> > ---help---
> > diff --git a/drivers/infiniband/hw/cxgb4/Kconfig b/drivers/infiniband/hw/cxgb4/Kconfig
> > index afe8b28e0878..7910fdd88619 100644
> > --- a/drivers/infiniband/hw/cxgb4/Kconfig
> > +++ b/drivers/infiniband/hw/cxgb4/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_CXGB4
> > tristate "Chelsio T4/T5 RDMA Driver"
> > depends on CHELSIO_T4 && INET && (IPV6 || IPV6=n)
> > + depends on PCI || BROKEN
> > select CHELSIO_LIB
> > select GENERIC_ALLOCATOR
> > ---help---
> > diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
> > index f6ea0881765a..5072d083f53b 100644
> > --- a/drivers/infiniband/hw/hfi1/Kconfig
> > +++ b/drivers/infiniband/hw/hfi1/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_HFI1
> > tristate "Intel OPA Gen1 support"
> > depends on X86_64 && INFINIBAND_RDMAVT && I2C
> > + depends on PCI || BROKEN
> > select MMU_NOTIFIER
> > select CRC32
> > select I2C_ALGOBIT
> > diff --git a/drivers/infiniband/hw/i40iw/Kconfig b/drivers/infiniband/hw/i40iw/Kconfig
> > index 6e7d27a14061..9cfef1370445 100644
> > --- a/drivers/infiniband/hw/i40iw/Kconfig
> > +++ b/drivers/infiniband/hw/i40iw/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_I40IW
> > tristate "Intel(R) Ethernet X722 iWARP Driver"
> > depends on INET && I40E
> > + depends on PCI || BROKEN
> > select GENERIC_ALLOCATOR
> > ---help---
> > Intel(R) Ethernet X722 iWARP Driver
> > diff --git a/drivers/infiniband/hw/qedr/Kconfig b/drivers/infiniband/hw/qedr/Kconfig
> > index 6c9f3923e838..8db2966f52c2 100644
> > --- a/drivers/infiniband/hw/qedr/Kconfig
> > +++ b/drivers/infiniband/hw/qedr/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_QEDR
> > tristate "QLogic RoCE driver"
> > depends on 64BIT && QEDE
> > + depends on PCI || BROKEN
> > select QED_LL2
> > select QED_RDMA
> > ---help---
> > diff --git a/drivers/infiniband/hw/qib/Kconfig b/drivers/infiniband/hw/qib/Kconfig
> > index e0fdb9201423..522a6fcaa9d8 100644
> > --- a/drivers/infiniband/hw/qib/Kconfig
> > +++ b/drivers/infiniband/hw/qib/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_QIB
> > tristate "Intel PCIe HCA support"
> > depends on 64BIT && INFINIBAND_RDMAVT
> > + depends on PCI || BROKEN
> > ---help---
> > This is a low-level driver for Intel PCIe QLE InfiniBand host
> > channel adapters. This driver does not support the Intel
> > diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
> > index fdd001ce13d8..605bfb1da9df 100644
> > --- a/drivers/infiniband/sw/rdmavt/Kconfig
> > +++ b/drivers/infiniband/sw/rdmavt/Kconfig
> > @@ -1,6 +1,7 @@
> > config INFINIBAND_RDMAVT
> > tristate "RDMA verbs transport library"
> > depends on 64BIT
> > + depends on PCI || BROKEN
> > select DMA_VIRT_OPS
> > ---help---
> > This is a common software verbs provider for RDMA networks.
>
> does the RDMAVT really depends on PCI, to me looks not, we can also
> remove the included in drivers/infiniband/sw/rdmavt/vt.h?
I thought that this is used by the set of macros just below (rvt_pr_*
family).
Anyway, tried that and got compilation errors.
(See function get_pci_dev declaration in include/rdma/rdma_vt.h)
>
> Other than this, I think the change make sense to me!
>
> Cheers,
> Jack
>
> > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > index 6c77df34869d..3fc3b7b20297 100644
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> > @@ -51,7 +51,6 @@
> > #include <net/addrconf.h>
> > #include <linux/inetdevice.h>
> > #include <rdma/ib_cache.h>
> > -#include <linux/pci.h>
> >
> > #define DRV_VERSION "1.0.0"
> >
> > --
> > 2.13.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <20170904152848.3471-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-04 15:48 ` Jack Wang
@ 2017-09-05 4:08 ` Leon Romanovsky
[not found] ` <20170905040826.GB1070-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
1 sibling, 1 reply; 8+ messages in thread
From: Leon Romanovsky @ 2017-09-05 4:08 UTC (permalink / raw)
To: Yuval Shaia
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
swise-ut6Up61K2wZBDgjK7y7TUQ,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]
On Mon, Sep 04, 2017 at 06:28:48PM +0300, Yuval Shaia wrote:
> No reason to have dependency on PCI for the entire infiniband stack so
> move it to KConfig of only the drivers that actually using PCI.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> v0 -> v1:
> * As suggested by Thomas Bogendoerfer:
> * Remove unneeded header inclusion from ipoib
> * Remove PCI dependency from ipoib's Kconfig
> ---
> drivers/infiniband/Kconfig | 1 -
> drivers/infiniband/hw/cxgb3/Kconfig | 1 +
> drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> drivers/infiniband/hw/hfi1/Kconfig | 1 +
> drivers/infiniband/hw/i40iw/Kconfig | 1 +
> drivers/infiniband/hw/qedr/Kconfig | 1 +
> drivers/infiniband/hw/qib/Kconfig | 1 +
> drivers/infiniband/sw/rdmavt/Kconfig | 1 +
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 1 -
> 9 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 234fe01904e7..568088a9298c 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,5 @@
> menuconfig INFINIBAND
> tristate "InfiniBand support"
> - depends on PCI || BROKEN
> depends on HAS_IOMEM
> depends on NET
> depends on INET
> diff --git a/drivers/infiniband/hw/cxgb3/Kconfig b/drivers/infiniband/hw/cxgb3/Kconfig
> index 2b6352b85485..bd32926afa77 100644
> --- a/drivers/infiniband/hw/cxgb3/Kconfig
> +++ b/drivers/infiniband/hw/cxgb3/Kconfig
> @@ -1,5 +1,6 @@
> config INFINIBAND_CXGB3
> tristate "Chelsio RDMA Driver"
> + depends on PCI || BROKEN
> depends on CHELSIO_T3 && INET
Yuval,
Why do we need to be dependent on CONFIG_BROKEN?
Is it still valid for IB stack?
Thanks,
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <20170905040826.GB1070-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-09-05 4:16 ` Bart Van Assche
[not found] ` <1504585010.3360.10.camel-Sjgp3cTcYWE@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Bart Van Assche @ 2017-09-05 4:16 UTC (permalink / raw)
To: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote:
> Why do we need to be dependent on CONFIG_BROKEN?
> Is it still valid for IB stack?
Hello Leon,
As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN"
part was introduced through the following patch:
From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001
From: Al Viro <viro@www.linux.org.uk>
Date: Tue, 23 Aug 2005 22:45:41 +0100
Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI)
infiniband uses PCI helpers all over the place (including the core parts) and
won't build without PCI.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
drivers/infiniband/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 79c8e2dd9c33..32cdfb30e9b4 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -1,6 +1,7 @@
menu "InfiniBand support"
config INFINIBAND
+ depends on PCI || BROKEN
tristate "InfiniBand support"
---help---
Core support for InfiniBand (IB). Make sure to also select
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <1504585010.3360.10.camel-Sjgp3cTcYWE@public.gmane.org>
@ 2017-09-05 4:34 ` Leon Romanovsky
2017-09-05 8:29 ` Yuval Shaia
1 sibling, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2017-09-05 4:34 UTC (permalink / raw)
To: Bart Van Assche
Cc: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote:
> On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote:
> > Why do we need to be dependent on CONFIG_BROKEN?
> > Is it still valid for IB stack?
>
> Hello Leon,
Thanks Bart,
It was 12 years ago and it is worth to try to build without BROKEN at all.
>
> As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN"
> part was introduced through the following patch:
>
>
> From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001
> From: Al Viro <viro-1walMZg8u8rXmaaqVzeoHQ@public.gmane.org>
> Date: Tue, 23 Aug 2005 22:45:41 +0100
> Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI)
>
> infiniband uses PCI helpers all over the place (including the core parts) and
> won't build without PCI.
>
> Signed-off-by: Al Viro <viro-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
> Signed-off-by: Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org>
> ---
> drivers/infiniband/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 79c8e2dd9c33..32cdfb30e9b4 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,7 @@
> menu "InfiniBand support"
>
> config INFINIBAND
> + depends on PCI || BROKEN
> tristate "InfiniBand support"
> ---help---
> Core support for InfiniBand (IB). Make sure to also select
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
[not found] ` <1504585010.3360.10.camel-Sjgp3cTcYWE@public.gmane.org>
2017-09-05 4:34 ` Leon Romanovsky
@ 2017-09-05 8:29 ` Yuval Shaia
2017-09-05 14:06 ` Bart Van Assche
1 sibling, 1 reply; 8+ messages in thread
From: Yuval Shaia @ 2017-09-05 8:29 UTC (permalink / raw)
To: Bart Van Assche
Cc: leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote:
> On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote:
> > Why do we need to be dependent on CONFIG_BROKEN?
> > Is it still valid for IB stack?
>
> Hello Leon,
>
> As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN"
> part was introduced through the following patch:
Can you elaborate more on (1) why BROKEN is needed and (2) why "&&" make
sense and "||" not?
>
>
> From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001
> From: Al Viro <viro-1walMZg8u8rXmaaqVzeoHQ@public.gmane.org>
> Date: Tue, 23 Aug 2005 22:45:41 +0100
> Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI)
>
> infiniband uses PCI helpers all over the place (including the core parts) and
> won't build without PCI.
>
> Signed-off-by: Al Viro <viro-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
> Signed-off-by: Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org>
> ---
> drivers/infiniband/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 79c8e2dd9c33..32cdfb30e9b4 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,7 @@
> menu "InfiniBand support"
>
> config INFINIBAND
> + depends on PCI || BROKEN
> tristate "InfiniBand support"
> ---help---
> Core support for InfiniBand (IB). Make sure to also select
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs
2017-09-05 8:29 ` Yuval Shaia
@ 2017-09-05 14:06 ` Bart Van Assche
0 siblings, 0 replies; 8+ messages in thread
From: Bart Van Assche @ 2017-09-05 14:06 UTC (permalink / raw)
To: yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Cc: faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
On Tue, 2017-09-05 at 11:29 +0300, Yuval Shaia wrote:
> On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote:
> > On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote:
> > > Why do we need to be dependent on CONFIG_BROKEN?
> > > Is it still valid for IB stack?
> >
> > Hello Leon,
> >
> > As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN"
> > part was introduced through the following patch:
>
> Can you elaborate more on (1) why BROKEN is needed and (2) why "&&" make
> sense and "||" not?
Hello Yuval,
Sorry if I was not clear enough. What I meant is that for broken drivers "&& BROKEN"
should be used instead of "|| BROKEN". My opinion is that "|| BROKEN" is neither
needed nor that it makes sense for InfiniBand.
Bart.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-05 14:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-04 15:28 [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs Yuval Shaia
[not found] ` <20170904152848.3471-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-04 15:48 ` Jack Wang
[not found] ` <CAD+HZHVH7dUeQ0ibCWNZHgdO-1zh1KGT4C+9h09TiOHx=1Fddw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-04 18:24 ` Yuval Shaia
2017-09-05 4:08 ` Leon Romanovsky
[not found] ` <20170905040826.GB1070-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-05 4:16 ` Bart Van Assche
[not found] ` <1504585010.3360.10.camel-Sjgp3cTcYWE@public.gmane.org>
2017-09-05 4:34 ` Leon Romanovsky
2017-09-05 8:29 ` Yuval Shaia
2017-09-05 14:06 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).