Re: [PATCH for-next v3 0/2] iw_cxgb4 pr_debug() changes for 4.14-rc

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Wed, 2017-09-27 at 13:05 +0530, Potnuri Bharat Teja wrote:
> Hi Doug,
> Current "v3" series is generated on top of your "for-next" branch 
> overriding previous submissions.
> Please consider these for smoother application of subsequent patches.
> 
> Changes since "v2"
> - Revert pr_debug()->pr_warn() change in fw4_ack().
> 
> Changes since original submission
> - Make patches on top of "for-next" branch.

OK, I've taken your v3 of these patches.  But something that jumped out
at me as a big issue, far bigger than I realized, is just how many
places in the iw_cxgb4 driver do BUG()s.  Unless the official answer is
"This can never happen" (in which case we just need to remove the
conditional and the BUG() behind the conditional, because they can
never happen), someone needs to spend some time making the iw_cxgb4
driver more tolerant of things that it might not like, but which
shouldn't bring the computer to a grinding halt.  In particular, I
think things like if (skb_cloned(skb)) BUG() does not seem appropriate
to me.  Are you really telling me that you can't find a way to
gracefully drop the skb you are working on and simply fail the current
operation instead of BUG()ing?

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html