From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
corbet-T1hC0tSOHrs@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kernel-6AxghH7DbtA@public.gmane.org,
ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
shamir.rabinovitch-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
chien.yen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] IB/ipoib: Enable pkey and device name decoupling
Date: Wed, 27 Sep 2017 10:14:17 -0400 [thread overview]
Message-ID: <1506521657.82712.23.camel@redhat.com> (raw)
In-Reply-To: <20170927093248.3819-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Wed, 2017-09-27 at 12:32 +0300, Yuval Shaia wrote:
> + /*
> + * (1) buf_after_dot check above makes it valid hexdigit
> .XXXX format
> + *
> + * Now verify if buf_before_dot is a valid net device name -
> + * (if it is not, then we are not in disallowed namespace)
> + */
> + if (__dev_get_by_name(&init_net, buf_before_dot) == NULL)
> + return false;
This is wrong. We don't use &init_net in ipoib any more, we are
namespace aware, so your patch must be namespace aware too.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-27 14:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 9:32 [PATCH] IB/ipoib: Enable pkey and device name decoupling Yuval Shaia
[not found] ` <20170927093248.3819-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-27 14:14 ` Doug Ledford [this message]
2017-09-27 15:01 ` Leon Romanovsky
[not found] ` <20170927150140.GF2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-27 19:03 ` Mukesh Kacker
[not found] ` <c98fc5c0-cb34-c960-4bbf-34422bbacd0e-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-28 13:45 ` Leon Romanovsky
2017-09-28 16:38 ` Jason Gunthorpe
2017-09-27 17:20 ` Mukesh Kacker
[not found] ` <78f7983f-dc6b-a42a-0b29-adb69777fa75-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-09-27 17:26 ` Yuval Shaia
2017-09-28 16:34 ` Jason Gunthorpe
[not found] ` <20170928163406.GB17880-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-28 16:47 ` Leon Romanovsky
[not found] ` <20170928164735.GC2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-09-28 16:53 ` Jason Gunthorpe
[not found] ` <20170928165305.GE17880-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-09-28 17:08 ` Leon Romanovsky
2017-10-15 5:47 ` Yuval Shaia
2017-10-15 6:27 ` Leon Romanovsky
2017-10-17 8:18 ` Jason Gunthorpe
[not found] ` <20171017081837.GA19107-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-17 10:21 ` Leon Romanovsky
[not found] ` <20171017102121.GM2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-19 6:11 ` Jason Gunthorpe
[not found] ` <20171019061100.GB6555-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-19 6:14 ` Leon Romanovsky
[not found] ` <20171019061405.GW2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-19 6:28 ` Alex Vesker
[not found] ` <c2f3b529-cc53-aef0-fdcf-e86e99360db0-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-21 19:42 ` Jason Gunthorpe
[not found] ` <20171021194215.GA4094-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-23 6:04 ` Leon Romanovsky
[not found] ` <20171023060436.GD2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-23 15:23 ` Jason Gunthorpe
[not found] ` <20171023152340.GA11952-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-23 17:03 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506521657.82712.23.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=chien.yen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ferasda-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-6AxghH7DbtA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mukesh.kacker-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=shamir.rabinovitch-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=valex-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).