From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH for-next 02/12] IB/hfi1: Convert the macro AHG_HEADER_SET into an inline function Date: Wed, 27 Sep 2017 11:38:11 -0400 Message-ID: <1506526691.33755.5.camel@redhat.com> References: <20170926135843.15601.95865.stgit@scvm10.sc.intel.com> <20170926140009.15601.38666.stgit@scvm10.sc.intel.com> <20170927152118.GG2297@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170927152118.GG2297-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , Dennis Dalessandro Cc: Harish Chegondi , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Marciniszyn List-Id: linux-rdma@vger.kernel.org On Wed, 2017-09-27 at 18:21 +0300, Leon Romanovsky wrote: > On Tue, Sep 26, 2017 at 07:00:11AM -0700, Dennis Dalessandro wrote: > > > > - AHG_HEADER_SET(ahg, diff, 0, 0, 12, > > - cpu_to_le16(LRH2PBC(lrhlen))); > > + idx = ahg_header_set(ahg, idx, array_size, 0, 0, > > 12, > > + (__force > > u16)cpu_to_le16(LRH2PBC(lrhlen))); > > This "__force" looks suspicious to me and I think you have an error > here by > using cpu_to_le16 instead of cpu_to_be16. I took this patch as is because it simply translates from the old to the new method of doing things. If there is a bug here in the use of le16 instead if be16, then it existed before too and should be fixed in a separate, incremental fix patch. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html