linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Yuval Shaia <yuval.shaia@oracle.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: add MMU dependency for user_mem
Date: Mon, 09 Oct 2017 12:26:36 -0400	[thread overview]
Message-ID: <1507566396.46071.40.camel@redhat.com> (raw)
In-Reply-To: <20171006071410.732275-1-arnd@arndb.de>

On Fri, 2017-10-06 at 09:13 +0200, Arnd Bergmann wrote:
> The infiniband subsystem causes a link failure when the umem
> driver is built on MMU-less systems:
> 
> mm/mmu_notifier.o: In function `do_mmu_notifier_register':
> mmu_notifier.c:(.text+0x32): undefined reference to
> `mm_take_all_locks'
> drivers/infiniband/core/umem.o: In function `ib_umem_get':
> umem.c:(.text+0x132): undefined reference to `can_do_mlock'
> drivers/infiniband/core/umem_odp.o: In function
> `ib_umem_odp_map_dma_pages':
> umem_odp.c:(.text+0x766): undefined reference to
> `get_user_pages_remote'
> 
> This bug has existed for a while but only become apparent in ARM
> randconfig builds when the dependency on PCI was lifted, as none
> of the ARM-NOMMU targets support PCI at the moment.
> 
> We could probably get the umem driver to build by providing an
> alternative implementation 'can_do_mlock()' that returns false
> on NOMMU-systems, but then we'd still have a problem with the
> mmu-notifiers required by CONFIG_INFINIBAND_ON_DEMAND_PAGING,
> so simply forbidding umem with NOMMU seems like the simplest
> workaround.
> 
> Fixes: 931bc0d91639 ("IB: Move PCI dependency from root KConfig to
> HW's KConfigs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

      reply	other threads:[~2017-10-09 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  7:13 [PATCH] infiniband: add MMU dependency for user_mem Arnd Bergmann
2017-10-09 16:26 ` Doug Ledford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507566396.46071.40.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=arnd@arndb.de \
    --cc=hal.rosenstock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).