From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] bnxt_re: Fix incorrect usage of test_bit() Date: Wed, 18 Oct 2017 10:26:51 -0400 Message-ID: <1508336811.46071.66.camel@redhat.com> References: <20171013060800.10371-1-somnath.kotur@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171013060800.10371-1-somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Somnath Kotur , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, 2017-10-13 at 11:38 +0530, Somnath Kotur wrote: > test_bit() takes a bit number while the 'flags' field in > struct bnxt_qplib_rcfw was using actual BIT position converted > values. > Fix this by assigning bit numbers and use consistent APIs > all the flag values. > Also logging a message in case of failure. > > Thanks to Dan Carpenter for pointing this out. > > Suggested-by: Dan Carpenter > Signed-off-by: Somnath Kotur Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html