Re: [PATCH] RDMA/netlink: OOPs in rdma_nl_rcv_msg() from misinterpreted flag

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Wed, 2017-10-25 at 22:06 +0300, Leon Romanovsky wrote:
> > I agree with Michael that tweaking this code to be optimal versus
> > plainly failsafe is a patch for another day.  I've taken this one.
> > Thanks Michael.
> 
> Too bad, you actually suggested very good solution, it is unclear who
> will now implement it.

I may do it myself.  I've been looking at the code and I don't like the
if construct because I don't feel it conveys the purpose of the code
clearly.  Implicit in the if construct is embedded knowledge about
which providers do what.  I'd rather have a switch construct on the
index with the flow split to those that have only .dump, those that
have only .doit, and those that have both.  The current if doesn't make
it clear that this is how the netlink services are structured.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html