Re: [PATCH v2 4/8] IB/srpt: Change default behavior from using SRQ to using RC

[Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1147 bytes --]

On Thu, 2017-11-02 at 18:30 +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH v2 4/8] IB/srpt: Change default behavior from using SRQ to
> > using RC
> 
> Bart, this last of the 4 target patches causes our internal SRP testing to
> fail.

Sorry for this. Since I assume that you are referring to tests with the qib
or hfi1 driver and since I do not have access to a setup with that hardware
I will have to rely on you for further analysis.

> I'm looking at why but...
> 
> > Add new configfs attributes that allow to configure which mode to use
> > (/sys/kernel/config/target/srpt/$GUID/$GUID/attrib/use_srq). Note:
> > only the attribute for port 1 is relevant on multi-port adapters.
> 
> It looks like the above work around cannot work.
> The use_srq is tested and the  SRQ is allocated when the device is added.
> Setting a target relative attribute is too late in the sequence to enable
> the old SRQ usage.

Thanks for the report. I will post a patch series to address this.

Bart.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dʇڙë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš