From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
'Leon Romanovsky' <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32
Date: Fri, 10 Nov 2017 13:05:56 -0500 [thread overview]
Message-ID: <1510337156.3735.7.camel@redhat.com> (raw)
In-Reply-To: <037e01d34dcd$845c1ce0$8d1456a0$@opengridcomputing.com>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Wed, 2017-10-25 at 15:12 -0500, Steve Wise wrote:
> >
> > Chelsio cxgb4 HW is big-endian, hence there is need to properly
> > annotate r2 and stag fields as __be32 and not __u32 to fix the
> > following sparse warnings.
> >
> > drivers/infiniband/hw/cxgb4/qp.c:614:16:
> > warning: incorrect type in assignment (different base types)
> > expected unsigned int [unsigned] [usertype] r2
> > got restricted __be32 [usertype] <noident>
> > drivers/infiniband/hw/cxgb4/qp.c:615:18:
> > warning: incorrect type in assignment (different base types)
> > expected unsigned int [unsigned] [usertype] stag
> > got restricted __be32 [usertype] <noident>
> >
> > Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> Looks fine. Thanks Leon!
>
> Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>
Applied, thanks.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-10 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 20:10 [PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32 Leon Romanovsky
[not found] ` <20171025201019.7367-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-10-25 20:12 ` Steve Wise
2017-11-10 18:05 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510337156.3735.7.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox