[PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32

[PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32

[Leon Romanovsky]

Chelsio cxgb4 HW is big-endian, hence there is need to properly
annotate r2 and stag fields as __be32 and not __u32 to fix the
following sparse warnings.

  drivers/infiniband/hw/cxgb4/qp.c:614:16:
    warning: incorrect type in assignment (different base types)
      expected unsigned int [unsigned] [usertype] r2
      got restricted __be32 [usertype] <noident>
  drivers/infiniband/hw/cxgb4/qp.c:615:18:
    warning: incorrect type in assignment (different base types)
      expected unsigned int [unsigned] [usertype] stag
      got restricted __be32 [usertype] <noident>

Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/t4fw_ri_api.h b/drivers/infiniband/hw/cxgb4/t4fw_ri_api.h
index 010c709ba3bb..58c531db4f4a 100644
--- a/drivers/infiniband/hw/cxgb4/t4fw_ri_api.h
+++ b/drivers/infiniband/hw/cxgb4/t4fw_ri_api.h
@@ -675,8 +675,8 @@ struct fw_ri_fr_nsmr_tpte_wr {
 	__u16  wrid;
 	__u8   r1[3];
 	__u8   len16;
-	__u32  r2;
-	__u32  stag;
+	__be32  r2;
+	__be32  stag;
 	struct fw_ri_tpte tpte;
 	__u64  pbl[2];
 };
--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32

[Steve Wise]

> 
> Chelsio cxgb4 HW is big-endian, hence there is need to properly
> annotate r2 and stag fields as __be32 and not __u32 to fix the
> following sparse warnings.
> 
>   drivers/infiniband/hw/cxgb4/qp.c:614:16:
>     warning: incorrect type in assignment (different base types)
>       expected unsigned int [unsigned] [usertype] r2
>       got restricted __be32 [usertype] <noident>
>   drivers/infiniband/hw/cxgb4/qp.c:615:18:
>     warning: incorrect type in assignment (different base types)
>       expected unsigned int [unsigned] [usertype] stag
>       got restricted __be32 [usertype] <noident>
> 
> Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Looks fine. Thanks Leon!

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next] RDMA/cxgb4: Annotate r2 and stag as __be32

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Wed, 2017-10-25 at 15:12 -0500, Steve Wise wrote:
> > 
> > Chelsio cxgb4 HW is big-endian, hence there is need to properly
> > annotate r2 and stag fields as __be32 and not __u32 to fix the
> > following sparse warnings.
> > 
> >   drivers/infiniband/hw/cxgb4/qp.c:614:16:
> >     warning: incorrect type in assignment (different base types)
> >       expected unsigned int [unsigned] [usertype] r2
> >       got restricted __be32 [usertype] <noident>
> >   drivers/infiniband/hw/cxgb4/qp.c:615:18:
> >     warning: incorrect type in assignment (different base types)
> >       expected unsigned int [unsigned] [usertype] stag
> >       got restricted __be32 [usertype] <noident>
> > 
> > Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> 
> Looks fine. Thanks Leon!
> 
> Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> 

Applied, thanks.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]