Re: [PATCH for-next] iw_cxgb4: remove BUG_ON() usage.

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

On Mon, 2017-11-06 at 09:23 -0500, Dennis Dalessandro wrote:
> On 11/2/2017 5:11 PM, Steve Wise wrote:
> > iw_cxgb4 has many BUG_ON()s that were left over from various enhancemnets
> > made over the years.  Almost all of them should just be removed.  Some,
> > however indicate a ULP usage error and can be handled w/o bringing down
> > the system.
> > 
> > If the condition cannot happen with correctly implemented cxgb4 sw/fw,
> > then remove the BUG_ON.
> > 
> > If the condition indicates a misbehaving ULP (like CQ overflows), add
> > proper recovery logic.
> > 
> > Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > ---
> >   drivers/infiniband/hw/cxgb4/cm.c       | 25 +++++++++----------------
> >   drivers/infiniband/hw/cxgb4/cq.c       | 10 ----------
> >   drivers/infiniband/hw/cxgb4/id_table.c |  1 -
> >   drivers/infiniband/hw/cxgb4/iw_cxgb4.h |  1 -
> >   drivers/infiniband/hw/cxgb4/provider.c |  4 ++--
> >   drivers/infiniband/hw/cxgb4/qp.c       |  3 ---
> >   drivers/infiniband/hw/cxgb4/t4.h       |  7 ++-----
> >   7 files changed, 13 insertions(+), 38 deletions(-)
> 
> Awesome to see these go away.
> 
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Thanks Steve, nice cleanup.  Applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]