public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core 1/6] debian: Let libibverbs1 16 break ibverbs-providers 15
Date: Wed, 15 Nov 2017 10:20:17 +0100	[thread overview]
Message-ID: <1510737617.4026.56.camel@profitbricks.com> (raw)
In-Reply-To: <20171114203939.GT4263-uk2M96/98Pc@public.gmane.org>

Am Dienstag, den 14.11.2017, 13:39 -0700 schrieb Jason Gunthorpe:
> On Tue, Nov 14, 2017 at 09:02:42PM +0100, Benjamin Drung wrote:
> > ibverbs-providers uses the private symbols of libibverbs1. Thus
> > libibverbs1 will not work with an old version version of
> > ibverbs-providers if the private symbol version is bumped.
> > 
> > Bump the ibverbs-providers version that libibverbs1 breaks which
> > was
> > forgotten on the symbol version bump. See also commit
> > 611b7cc3b8e0d79aa986f042f486fccc95d73679. Append a tilde to support
> > the lower version numbers (e.g. 16~201711132208) in the PPA builds.
> 
> This seems strange to me, we don't really need Breaks semantics here.
> 
> Shouldn't we do something like:
> 
> Package: ibverbs-providers
> Depends: [..], libibverbs1 (= ${binary:Version}),
> 
> ?

We had exactly that previously and commit
611b7cc3b8e0d79aa986f042f486fccc95d73679 changed that behavior. See
there for a reasoning. When building, ibverbs-provides will get an
dependency on libibverbs1 (>= X) where X matches the major number from
the private symbols (currently X = 16)

> We really do not want to encourage mixing and matching versions.

The current way with Breaks allows one to mix and match only within one
 major release. So you could use ibverbs-provides 15.1 with libibverbs1
15 (but not with 14 or 16).

> IIRC the existing breaks is only because of how the new packages
> interact with the legacy ones??

The Provides & Replaces & Breaks in ibverbs-providers are there for
upgrading from the old package names to ibverbs-providers.

-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
URL: https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-15  9:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 20:02 [PATCH rdma-core 0/6] More Debian packaging cleanup Benjamin Drung
     [not found] ` <20171114200247.25890-1-benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-11-14 20:02   ` [PATCH rdma-core 1/6] debian: Let libibverbs1 16 break ibverbs-providers 15 Benjamin Drung
     [not found]     ` <20171114200247.25890-2-benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-11-14 20:39       ` Jason Gunthorpe
     [not found]         ` <20171114203939.GT4263-uk2M96/98Pc@public.gmane.org>
2017-11-15  9:20           ` Benjamin Drung [this message]
2017-11-14 20:02   ` [PATCH rdma-core 2/6] debian: Replace priority extra by optional Benjamin Drung
2017-11-14 20:02   ` [PATCH rdma-core 3/6] debian: Relax dh-systemd build dependency Benjamin Drung
2017-11-14 20:02   ` [PATCH rdma-core 4/6] debian: Bump Standards-Version to 4.1.1 Benjamin Drung
2017-11-14 20:02   ` [PATCH rdma-core 5/6] debian: Drop lintian overrides for false positives Benjamin Drung
2017-11-14 20:02   ` [PATCH rdma-core 6/6] debian: Run wrap-and-sort Benjamin Drung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510737617.4026.56.camel@profitbricks.com \
    --to=benjamin.drung-eikl63zcoxah+58jc4qpia@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox