Re: [PATCH 00/28] IB/srp and IB/srpt patches

Bart Van Assche
2018-01-03T22:06:56Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1267 bytes --]

On Wed, 2018-01-03 at 14:51 -0700, Jason Gunthorpe wrote:
> On Wed, Jan 03, 2018 at 01:39:10PM -0800, Bart Van Assche wrote:
> > Hello Jason,
> >
> > This patch series adds RDMA/CM support to the SRP initiator and target drivers
> > and also includes a series of bug fixes for the SRPT driver. Please consider
> > at least the SRPT bug fixes for kernel v4.16 since one of these fixes is a
> > security fix.
>
> Bart, this is really big for the rc6 timeframe.. This might make it if
> there is a rc8 this cycle.
>
> I'll grab the two patches marked for stable to for-rc, they look
> trivial.
>
> I'm with the DaveM school of thought here that patch series should be
> 10-15 at most, and have a clear purpose, even if that purpose is just
> 'assorted one patch fixes'.. If you resend it can you split the series?

Hello Jason,

How about splitting this series as follows:
* Patches 1..4 with the SRP initiator changes.
* Patches 5..6 with the SRPT bugfixes that have the "Cc: stable" tag.
* Patches 7,8,11..19 with trival SRPT changes.
* Patches 9,10,20..28 with the deeper SRPT changes.

Thanks,

Bart.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš