Re: [PATCH 05/28] IB/srpt: Disable RDMA access by the initiator

Jason Gunthorpe
2018-01-04T03:12:02Z

On Wed, Jan 03, 2018 at 01:39:15PM -0800, Bart Van Assche wrote:
> With the SRP protocol all RDMA operations are initiated by the target.
> Since no RDMA operations are initiated by the initiator, do not grant
> the initiator permission to submit RDMA reads or writes to the target.
>
> Signed-off-by: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 8a1bd354b1cc..7c4249038004 100644
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -1013,8 +1013,7 @@ static int srpt_init_ch_qp(struct srpt_rdma_ch *ch, struct ib_qp *qp)
> return -ENOMEM;
>
> attr->qp_state = IB_QPS_INIT;
> - attr->qp_access_flags = IB_ACCESS_LOCAL_WRITE | IB_ACCESS_REMOTE_READ |
> - IB_ACCESS_REMOTE_WRITE;
> + attr->qp_access_flags = IB_ACCESS_LOCAL_WRITE;
> attr->port_num = ch->sport->port;
> attr->pkey_index = 0;

Applied to for-rc thanks

Jason