From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 4/4] IB/srp: Add RDMA/CM support
Date: Mon, 8 Jan 2018 21:20:55 +0000 [thread overview]
Message-ID: <1515446454.2909.21.camel@wdc.com> (raw)
In-Reply-To: <1515444821.3403.92.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Mon, 2018-01-08 at 15:53 -0500, Doug Ledford wrote:
> On Mon, 2018-01-08 at 10:55 -0800, Bart Van Assche wrote:
> > + new_cm_id = rdma_create_id(&init_net, srp_rdma_cm_handler, ch,
> > + RDMA_PS_TCP, IB_QPT_RC);
>
> which clearly drops whatever namespace we are supposed to be in and
> creates new cm_ids in the init namespace.
That's an oversight. I will address this and repost the series.
Bart.
prev parent reply other threads:[~2018-01-08 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 18:55 [PATCH v2 0/4] IB/srp: Add RDMA/CM support Bart Van Assche
[not found] ` <20180108185549.30377-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2018-01-08 18:55 ` [PATCH v2 1/4] IB/srp: Use kstrtoull() instead of simple_strtoull() Bart Van Assche
2018-01-08 18:55 ` [PATCH v2 2/4] IB/srp: Make the path record query error message more informative Bart Van Assche
2018-01-08 18:55 ` [PATCH v2 3/4] IB/srp: Refactor srp_send_req() Bart Van Assche
2018-01-08 18:55 ` [PATCH v2 4/4] IB/srp: Add RDMA/CM support Bart Van Assche
[not found] ` <20180108185549.30377-5-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2018-01-08 20:53 ` Doug Ledford
[not found] ` <1515444821.3403.92.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-08 21:20 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515446454.2909.21.camel@wdc.com \
--to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox