From: Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hannes Reinecke <hare-l3A5Bk7waGM@public.gmane.org>,
Hannes Reinecke <hare-IBi9RG/b67k@public.gmane.org>,
Steve Schremmer
<sschremm-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter
Date: Wed, 10 Jan 2018 10:07:36 +0100 [thread overview]
Message-ID: <1515575256-9949-1-git-send-email-hare@suse.de> (raw)
The module parameter 'iser_pi_guard' has been disabled by commit
5bb6e543d2a7d58 ("IB/iser: DIX update"), but the functionality
to select the guard algorithm is still required.
Fixes: 5bb6e543d2a7d58 ("IB/iser: DIX update")
Signed-off-by: Hannes Reinecke <hare-IBi9RG/b67k@public.gmane.org>
Cc: Steve Schremmer <sschremm-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 19624e0..34c4d0a 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -649,8 +649,10 @@ static void iscsi_iser_cleanup_task(struct iscsi_task *task)
u32 sig_caps = ib_conn->device->ib_device->attrs.sig_prot_cap;
scsi_host_set_prot(shost, iser_dif_prot_caps(sig_caps));
- scsi_host_set_guard(shost, SHOST_DIX_GUARD_IP |
- SHOST_DIX_GUARD_CRC);
+ if (iser_pi_guard)
+ scsi_host_set_guard(shost, SHOST_DIX_GUARD_IP);
+ else
+ scsi_host_set_guard(shost, SHOST_DIX_GUARD_CRC);
}
if (iscsi_host_add(shost,
--
1.8.5.6
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-01-10 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:07 Hannes Reinecke [this message]
[not found] ` <1515575256-9949-1-git-send-email-hare-l3A5Bk7waGM@public.gmane.org>
2018-01-10 23:02 ` [PATCH] iscsi_iser: Re-enable 'iser_pi_guard' module parameter Jason Gunthorpe
[not found] ` <20180110230240.GR4518-uk2M96/98Pc@public.gmane.org>
2018-01-11 0:04 ` Schremmer, Steven
[not found] ` <CY4PR0601MB35860D768905FF165DB99A048C160-HWnCAiYGO2rYxEunYmvS1/tZqYE1FQh9nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-11 16:58 ` Jason Gunthorpe
[not found] ` <20180111165822.GC1309-uk2M96/98Pc@public.gmane.org>
2018-01-11 17:24 ` Bart Van Assche
2018-01-14 9:34 ` Sagi Grimberg
[not found] ` <a3d8060a-3926-0ba1-8963-b66d37172027-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-01-16 2:57 ` Martin K. Petersen
[not found] ` <yq1r2qqy0ho.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-16 11:20 ` Hannes Reinecke
[not found] ` <22838a0f-29d5-7351-12d3-05a0948fd0ba-IBi9RG/b67k@public.gmane.org>
2018-01-17 5:09 ` Martin K. Petersen
[not found] ` <yq1d129ul4d.fsf-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-17 9:59 ` Sagi Grimberg
[not found] ` <651bc1dd-f019-637c-1f76-07938b3041ce-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-01-17 20:43 ` Schremmer, Steven
[not found] ` <CY4PR0601MB3586E4314AF5B70DDA8F381A8CE90-HWnCAiYGO2rYxEunYmvS1/tZqYE1FQh9nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-18 2:04 ` Martin K. Petersen
2018-01-17 9:54 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515575256-9949-1-git-send-email-hare@suse.de \
--to=hare-l3a5bk7wagm@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hare-IBi9RG/b67k@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=sschremm-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox