Re: Kernel v4.16 / v4.17 SRP and SRPT patches

Bart Van Assche
2018-01-12T21:11:13Z

On Thu, 2018-01-11 at 16:33 -0500, Laurence Oberman wrote:
> I just rebooted the server into 4.13 and its fine again and found all
> the targets with the same kernel on the client.
>
> So its specific to your new tree with srpt
>
> I will reboot again and re-load LIO and show you but here is my ACL
> list that has been this way for some time.
>
>
> o- srpt
> .......................................................................
> ...................................... [Targets: 2]
> | o- ib.fe800000000000007cfe900300726e4e
> .......................................................................
> .... [no-gen-acls]
> | | o- acls
> .......................................................................
> ..................................... [ACLs: 8]
> | | | o- ib.4e6e72000390fe7c7cfe900300726ed2
>
> [ ... ]

Hello Laurence,

Although I'm not sure I think I found the root cause of this failure. The
following patch should fix the failure:

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 96142110a155..5297963c834d 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -2083,7 +2083,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
struct ib_cm_rep_param ib_cm;
} *rep_param = NULL;
struct srpt_rdma_ch *ch;
- char i_port_id[24];
+ char i_port_id[36];
u32 it_iu_len;
int i, ret;

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h
index bf4525b24d98..02883f8e9c71 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.h
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.h
@@ -308,7 +308,7 @@ struct srpt_rdma_ch {
bool using_rdma_cm;
bool processing_wait_list;
struct se_session *sess;
- u8 sess_name[36];
+ u8 sess_name[24];
struct work_struct release_work;
};

I wrote "should" because targetcli is not installed on my test setup and
because I have not yet verified this change with targetcli. If you have the
time to verify this change that would be great. If not then I will install
targetcli myself and verify this change.

Thanks,

Bart.