Re: Kernel v4.16 / v4.17 SRP and SRPT patches

Jason Gunthorpe
2018-01-10T20:52:43Z

On Wed, Jan 10, 2018 at 02:30:39PM -0500, Laurence Oberman wrote:

> Just to be clear, I have posted two types of stack traces, one where I
> panic the other here above where I am not panicking.

Guessing it is just luck which you hit.. Random corrupted memory and
all..

> This is not any special type of test. I booted the kernel, mapped
> the SRP devices from the target server and proceeded to shutdown the
> client with shutdown -r now. This is part of my holistic test I
> always do against new patches in Bart's tree. I start with reboots,
> them rmmod's etc. before I go on to perform I/O against the LUNS
> from the target.

Well, your shtudown is triggering the mlx driver shutdown code,
then it looks like the SRP stuff gets cleaned up? That certainly is
getting a bit exciting code wise

I see there have been some changes in the mlx5 shutdown handling
recently..

As an experiment comment out the '.shutdown = shutdown' in
drivers/net/ethernet/mellanox/mlx5/core/main.c?

And it would be interesting to know if your past success kernels were
printing the mlx5 shutdown message too? Perhaps something core kernel
changed to enable this path for your test?

Jason