Re: Kernel v4.16 / v4.17 SRP and SRPT patches

Laurence Oberman
2018-01-13T14:53:46Z

On Fri, 2018-01-12 at 20:57 -0500, Laurence Oberman wrote:
> On Fri, 2018-01-12 at 19:09 -0500, Laurence Oberman wrote:
> > On Fri, 2018-01-12 at 21:11 +0000, Bart Van Assche wrote:
> > > On Thu, 2018-01-11 at 16:33 -0500, Laurence Oberman wrote:
> > > > I just rebooted the server into 4.13 and its fine again and
> > > > found
> > > > all
> > > > the targets with the same kernel on the client.
> > > >
> > > > So its specific to your new tree with srpt
> > > >
> > > > I will reboot again and re-load LIO and show you but here is my
> > > > ACL
> > > > list that has been this way for some time.
> > > >
> > > >
> > > > o- srpt
> > > > ...............................................................
> > > > ..
> > > > ..
> > > > ....
> > > > ...................................... [Targets: 2]
> > > >   | o- ib.fe800000000000007cfe900300726e4e
> > > > ...............................................................
> > > > ..
> > > > ..
> > > > ....
> > > > .... [no-gen-acls]
> > > >   | | o- acls
> > > > ...............................................................
> > > > ..
> > > > ..
> > > > ....
> > > > ..................................... [ACLs: 8]
> > > >   | | | o- ib.4e6e72000390fe7c7cfe900300726ed2
> > > >
> > > > [ ... ]
> > >
> > > Hello Laurence,
> > >
> > > Although I'm not sure I think I found the root cause of this
> > > failure.
> > > The
> > > following patch should fix the failure:
> > >
> > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
> > > b/drivers/infiniband/ulp/srpt/ib_srpt.c
> > > index 96142110a155..5297963c834d 100644
> > > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> > > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> > > @@ -2083,7 +2083,7 @@ static int srpt_cm_req_recv(struct
> > > srpt_device
> > > *const sdev,
> > >   struct ib_cm_rep_param ib_cm;
> > >   } *rep_param = NULL;
> > >   struct srpt_rdma_ch *ch;
> > > - char i_port_id[24];
> > > + char i_port_id[36];
> > >   u32 it_iu_len;
> > >   int i, ret;
> > >
> > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h
> > > b/drivers/infiniband/ulp/srpt/ib_srpt.h
> > > index bf4525b24d98..02883f8e9c71 100644
> > > --- a/drivers/infiniband/ulp/srpt/ib_srpt.h
> > > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h
> > > @@ -308,7 +308,7 @@ struct srpt_rdma_ch {
> > >   bool using_rdma_cm;
> > >   bool processing_wait_list;
> > >   struct se_session *sess;
> > > - u8 sess_name[36];
> > > + u8 sess_name[24];
> > >   struct work_struct release_work;
> > >  };
> > >
> > >
> > > I wrote "should" because targetcli is not installed on my test
> > > setup
> > > and
> > > because I have not yet verified this change with targetcli. If
> > > you
> > > have the
> > > time to verify this change that would be great. If not then I
> > > will
> > > install
> > > targetcli myself and verify this change.
> > >
> > > Thanks,
> > >
> > > Bart.NrybXǧv^)޺{.n+{ٚ{ay\x1d
ʇڙ,j\afhz\x1e
w\f
j:+vwjm\azZ+ݢj"!
> >
> >
> > Hi Bart
> >
> > I will get this tested tonight and report back.
> >
> > Fix makes sesne.
> >
> > Regards
> > Laurence
>
> Hello Bart
> For the patch above:
>
> This corrects the connectivity issue with LIO targets and I will
> continue now testing your patches from your tree.
>
> Reviewed-by: Laurence Oberman <loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Tested-by:   Laurence Oberman <loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Thank you for your quick response Sir.
>
> Laurence
>

Hello Bart

I missed some logs when I tested last night.
Its working fine as mentioned with the the above patch and I see all
the targets (That's what I checked for).

However I still see these in the srpt server, but I get access to all
the targets now on the client.

[  239.502025] ib_srpt Received SRP_LOGIN_REQ with i_port_id
7cfe:9003:0072:6e4f:7cfe:9003:0072:6ed3, t_port_id
7cfe:9003:0072:6e4e:7cfe:9003:0072:6e4e and it_iu_len 2116 on port 1
(guid=fe80:0000:0000:0000:7cfe:9003:0072:6e4f); pkey 0xffff
[  239.623881] ib_srpt failed to create queue pair with sq_size = 16384
(-12) - retrying
[  239.669381] ib_srpt failed to create queue pair with sq_size = 8192
(-12) - retrying
[  239.715366] ib_srpt Received SRP_LOGIN_REQ with i_port_id
7cfe:9003:0072:6e4e:7cfe:9003:0072:6ed2, t_port_id
7cfe:9003:0072:6e4e:7cfe:9003:0072:6e4e and it_iu_len 2116 on port 1
(guid=fe80:0000:0000:0000:7cfe:9003:0072:6e4e); pkey 0xffff
[  239.831661] ib_srpt failed to create queue pair with sq_size = 16384
(-12) - retrying
[  239.877193] ib_srpt failed to create queue pair with sq_size = 8192
(-12) - retrying
[  239.967259] ib_srpt Received SRP_LOGIN_REQ with i_port_id
7cfe:9003:0072:6e4f:7cfe:9003:0072:6ed3, t_port_id
7cfe:9003:0072:6e4e:7cfe:9003:0072:6e4e and it_iu_len 2116 on port 1
(guid=fe80:0000:0000:0000:7cfe:9003:0072:6e4f); pkey 0xffff
[  240.087362] ib_srpt failed to create queue pair with sq_size = 16384
(-12) - retrying
[  240.130981] ib_srpt failed to create queue pair with sq_size = 8192
(-12) - retrying
..
..

So the functional report was valid but we need to see why we are still
getting the messages above.

Apologies, should have checked all the logs last night before my first
reply.