Re: [PATCH rdma-next v4 2/7] RDMA/core: Add helper function to create named QPs

[Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>]

On Mon, 2018-01-15 at 17:12 +0200, Leon Romanovsky wrote:
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1141,6 +1141,12 @@ struct ib_qp_init_attr {
>  	u8			port_num;
>  	struct ib_rwq_ind_table *rwq_ind_tbl;
>  	u32			source_qpn;
> +
> +	/*
> +	 * Name of entity which created this QP, empty string means that
> +	 * it will be taken automatically from task_struct.
> +	 */
> +	char comm[TASK_COMM_LEN];
>  };

Why is comm[] an array? For queue pairs created from user space, are there any
queue pairs that can live longer than the task that created them? If not, does
that mean that it is safe to change comm into a const char pointer?

Additionally, please use the kernel-doc syntax to document structure members.

Thanks,

Bart.