[PATCH rdma-core] cbuild: Add Fedora 27 container

[PATCH rdma-core] cbuild: Add Fedora 27 container

[Leon Romanovsky]

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Add Fedora 27 to the list of cbuild targets.

Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 buildlib/cbuild | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/buildlib/cbuild b/buildlib/cbuild
index 3f659bf8..0ef80b60 100755
--- a/buildlib/cbuild
+++ b/buildlib/cbuild
@@ -141,6 +141,20 @@ class fc26(Environment):
             " ".join(sorted(self.pkgs))));
         return res;

+class fc27(Environment):
+    docker_parent = "fedora:27";
+    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};
+    name = "fc27";
+    specfile = "redhat/rdma-core.spec";
+    ninja_cmd = "ninja-build";
+    is_rpm = True;
+
+    def get_docker_file(self):
+        res = DockerFile(self.docker_parent);
+        res.lines.append("RUN dnf install -y %s && dnf clean all"%(
+            " ".join(sorted(self.pkgs))));
+        return res;
+
 # -------------------------------------------------------------------------

 class APTEnvironment(Environment):
@@ -337,6 +351,7 @@ environments = [centos6(),
                 jessie(),
                 stretch(),
                 fc26(),
+                fc27(),
                 leap(),
                 tumbleweed(),
                 debian_experimental(),
--
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] cbuild: Add Fedora 27 container

[Jason Gunthorpe]

On Fri, Jan 12, 2018 at 01:52:09PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Add Fedora 27 to the list of cbuild targets.
> 
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>  buildlib/cbuild | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/buildlib/cbuild b/buildlib/cbuild
> index 3f659bf8..0ef80b60 100755
> +++ b/buildlib/cbuild
> @@ -141,6 +141,20 @@ class fc26(Environment):
>              " ".join(sorted(self.pkgs))));
>          return res;
> 
> +class fc27(Environment):
> +    docker_parent = "fedora:27";
> +    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};
> +    name = "fc27";
> +    specfile = "redhat/rdma-core.spec";
> +    ninja_cmd = "ninja-build";
> +    is_rpm = True;
> +
> +    def get_docker_file(self):
> +        res = DockerFile(self.docker_parent);
> +        res.lines.append("RUN dnf install -y %s && dnf clean all"%(
> +            " ".join(sorted(self.pkgs))));
> +        return res;
> +
>  # -------------------------------------------------------------------------
> 
>  class APTEnvironment(Environment):
> @@ -337,6 +351,7 @@ environments = [centos6(),
>                  jessie(),
>                  stretch(),
>                  fc26(),
> +                fc27(),

I've been keeping only 1 fc container, no need to test old fedora.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] cbuild: Add Fedora 27 container

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Fri, Jan 12, 2018 at 11:08:55AM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 12, 2018 at 01:52:09PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > Add Fedora 27 to the list of cbuild targets.
> >
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >  buildlib/cbuild | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/buildlib/cbuild b/buildlib/cbuild
> > index 3f659bf8..0ef80b60 100755
> > +++ b/buildlib/cbuild
> > @@ -141,6 +141,20 @@ class fc26(Environment):
> >              " ".join(sorted(self.pkgs))));
> >          return res;
> >
> > +class fc27(Environment):
> > +    docker_parent = "fedora:27";
> > +    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};
> > +    name = "fc27";
> > +    specfile = "redhat/rdma-core.spec";
> > +    ninja_cmd = "ninja-build";
> > +    is_rpm = True;
> > +
> > +    def get_docker_file(self):
> > +        res = DockerFile(self.docker_parent);
> > +        res.lines.append("RUN dnf install -y %s && dnf clean all"%(
> > +            " ".join(sorted(self.pkgs))));
> > +        return res;
> > +
> >  # -------------------------------------------------------------------------
> >
> >  class APTEnvironment(Environment):
> > @@ -337,6 +351,7 @@ environments = [centos6(),
> >                  jessie(),
> >                  stretch(),
> >                  fc26(),
> > +                fc27(),
>
> I've been keeping only 1 fc container, no need to test old fedora.

I'll remove the rest.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core] cbuild: Add Fedora 27 container

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Add Fedora 27 to the list of cbuild targets.
> 
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  buildlib/cbuild | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/buildlib/cbuild b/buildlib/cbuild
> index 3f659bf8..0ef80b60 100755
> --- a/buildlib/cbuild
> +++ b/buildlib/cbuild
> @@ -141,6 +141,20 @@ class fc26(Environment):
>              " ".join(sorted(self.pkgs))));
>          return res;
> 
> +class fc27(Environment):
> +    docker_parent = "fedora:27";
> +    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};

Is there some reason why are you pulling a fedora:27 container and then
centos packages?



-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core] cbuild: Add Fedora 27 container

[Jason Gunthorpe]

On Wed, Jan 17, 2018 at 10:14:37AM -0500, Doug Ledford wrote:
> On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > 
> > Add Fedora 27 to the list of cbuild targets.
> > 
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >  buildlib/cbuild | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/buildlib/cbuild b/buildlib/cbuild
> > index 3f659bf8..0ef80b60 100755
> > +++ b/buildlib/cbuild
> > @@ -141,6 +141,20 @@ class fc26(Environment):
> >              " ".join(sorted(self.pkgs))));
> >          return res;
> > 
> > +class fc27(Environment):
> > +    docker_parent = "fedora:27";
> > +    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};
> 
> Is there some reason why are you pulling a fedora:27 container and then
> centos packages?

That is the pattern, centos7 has a list of required packages that is
most similar to fc27. It will make more sense when the patch is respun
to have fc27 replace fc26..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] cbuild: Add Fedora 27 container

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On Wed, Jan 17, 2018 at 09:16:14AM -0700, Jason Gunthorpe wrote:
> On Wed, Jan 17, 2018 at 10:14:37AM -0500, Doug Ledford wrote:
> > On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >
> > > Add Fedora 27 to the list of cbuild targets.
> > >
> > > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >  buildlib/cbuild | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > >
> > > diff --git a/buildlib/cbuild b/buildlib/cbuild
> > > index 3f659bf8..0ef80b60 100755
> > > +++ b/buildlib/cbuild
> > > @@ -141,6 +141,20 @@ class fc26(Environment):
> > >              " ".join(sorted(self.pkgs))));
> > >          return res;
> > >
> > > +class fc27(Environment):
> > > +    docker_parent = "fedora:27";
> > > +    pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"};
> >
> > Is there some reason why are you pulling a fedora:27 container and then
> > centos packages?
>
> That is the pattern, centos7 has a list of required packages that is
> most similar to fc27. It will make more sense when the patch is respun
> to have fc27 replace fc26..

I'll do.

Thanks

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]