Re: [PATCH v5 0/3] IB/srp patches for kernel v4.16

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2514 bytes --]

On Mon, 2018-01-22 at 14:27 -0800, Bart Van Assche wrote:
> Hello Jason and Doug,
> 
> The patches in this series add RDMA/CM support to the SRP initiator and also
> add a debug option. Please consider these patches for kernel v4.16.
> 
> Thanks,
> 
> Bart.

Hi Bart,

I took the series as is.  But, I don't know the target core well enough
to know what the third patch actually does (that doesn't impact my
decision to take it, it's a knob into the target core to allow you to
tweak things, that's obvious enough and since you find it useful, I have
no problem with it).  I know the cmd_per_lun setting sets the queue
depth of the scsi device on the initiator side, I would have assumed
that normally mirrors the advertised ability of the target, but this
patch now makes me think otherwise.  So what does this third patch
actually do to the target code?

> Changes compared to v4:
> - Left out the patches that have already been queued for kernel v4.16.
> - Added Greg's ack to patch 1/3.
> - Added a third patch that adds the starget_can_queue login option.
> 
> Changes compared to v3:
> - Moved a kobj_ns_drop() call inside an if-statement to keep the grab and put
>   ns calls balanced.
> 
> Changes compared to v2:
> - Added a patch that exports kobj_ns_grab_current() and kobj_ns_drop().
> - Made the rdma_create_id() call also use the namespace of the process that
>   triggered SRP login. Added kobj_ns_grab_current() and kobj_ns_drop() calls
>   to the SRP initiator to ensure that that network namespace exists at least
>   as long as the SRP channel that is using it.
> 
> Changes compared to v1:
> - Use the network namespace of the process that writes into the SRP sysfs login
>   attribute in rdma_create_id() and inet_pton_with_scope() calls.
> - Removed an irrelevant part from the RDMA/CM patch description.
> 
> Bart Van Assche (3):
>   kobject: Export kobj_ns_grab_current() and kobj_ns_drop()
>   IB/srp: Add RDMA/CM support
>   IB/srp: Add target_can_queue login parameter
> 
>  drivers/infiniband/ulp/srp/ib_srp.c | 723 ++++++++++++++++++++++++++++--------
>  drivers/infiniband/ulp/srp/ib_srp.h |  43 ++-
>  include/scsi/srp.h                  |  17 +
>  lib/kobject.c                       |   2 +
>  4 files changed, 631 insertions(+), 154 deletions(-)
> 

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]