public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: "jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org"
	<paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error
Date: Tue, 23 Jan 2018 22:30:08 +0000	[thread overview]
Message-ID: <1516746607.3339.47.camel@wdc.com> (raw)
In-Reply-To: <20180123185732.GA1393-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>

On Tue, 2018-01-23 at 20:57 +0200, Leon Romanovsky wrote:
> So how are we going to solve that rdma/for-next doesn't compile?

How about the following?

[PATCH] IB/srpt: Fix CONFIG_DEBUG_OBJECTS_RCU_HEAD=y build

Avoid that the kernel build fails as follows if RCU debugging is
enabled:

ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 5ccc75c389e2..a78a79791950 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -1977,7 +1977,6 @@ static struct srpt_nexus *srpt_get_nexus(struct srpt_port *sport,
 			nexus = ERR_PTR(-ENOMEM);
 			break;
 		}
-		init_rcu_head(&tmp_nexus->rcu);
 		INIT_LIST_HEAD(&tmp_nexus->ch_list);
 		memcpy(tmp_nexus->i_port_id, i_port_id, 16);
 		memcpy(tmp_nexus->t_port_id, t_port_id, 16);
@@ -2147,7 +2146,6 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
 		goto reject;
 	}
 
-	init_rcu_head(&ch->rcu);
 	kref_init(&ch->kref);
 	ch->pkey = be16_to_cpu(pkey);
 	ch->nexus = nexus;

  parent reply	other threads:[~2018-01-23 22:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 11:50 [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error Leon Romanovsky
     [not found] ` <20180123115013.12213-1-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-01-23 15:21   ` Jason Gunthorpe
     [not found]     ` <20180123152142.GB30619-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-01-23 16:04       ` Bart Van Assche
     [not found]         ` <1516723456.3339.3.camel-Sjgp3cTcYWE@public.gmane.org>
2018-01-23 18:57           ` Leon Romanovsky
     [not found]             ` <20180123185732.GA1393-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-23 22:30               ` Bart Van Assche [this message]
     [not found]                 ` <1516746607.3339.47.camel-Sjgp3cTcYWE@public.gmane.org>
2018-01-24  6:44                   ` Leon Romanovsky
2018-01-24 22:36                   ` Doug Ledford
     [not found]                     ` <1516833393.27592.108.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-24 22:40                       ` Bart Van Assche
     [not found]                         ` <1516833624.3987.19.camel-Sjgp3cTcYWE@public.gmane.org>
2018-01-25  1:19                           ` Doug Ledford
2018-01-23 22:03           ` Paul E. McKenney
     [not found]             ` <20180123220337.GE3741-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2018-01-23 22:29               ` Bart Van Assche
     [not found]                 ` <1516746545.3339.46.camel-Sjgp3cTcYWE@public.gmane.org>
2018-01-23 22:50                   ` Paul E. McKenney
     [not found]                     ` <20180123225054.GK3741-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2018-01-23 22:59                       ` Bart Van Assche
     [not found]                         ` <1516748369.3339.59.camel-Sjgp3cTcYWE@public.gmane.org>
2018-01-24  6:43                           ` Leon Romanovsky
     [not found]                             ` <20180124064337.GB1393-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-24 21:51                               ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516746607.3339.47.camel@wdc.com \
    --to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox