From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org"
<sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
"jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>,
"nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org"
<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>,
"pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
<pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
"aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
<aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
"hare-IBi9RG/b67k@public.gmane.org"
<hare-IBi9RG/b67k@public.gmane.org>,
"jgg-uk2M96/98Pc@public.gmane.org"
<jgg-uk2M96/98Pc@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2] RDMA: Use standard way to check return value
Date: Wed, 24 Jan 2018 15:06:02 +0000 [thread overview]
Message-ID: <1516806357.3324.1.camel@wdc.com> (raw)
In-Reply-To: <20180124124301.10884-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Wed, 2018-01-24 at 14:43 +0200, Yuval Shaia wrote:
> To be compatible with other modules/drivers, change return code checks
> from "if (rc != 0)" to "if (rc)".
Sorry but I think this is a completely pointless change. All the code that is
touched by this patch works fine, conforms to all appropriate coding style
guides and is easy to read. So why change it?
Bart.
next prev parent reply other threads:[~2018-01-24 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 12:43 [PATCH v2] RDMA: Use standard way to check return value Yuval Shaia
[not found] ` <20180124124301.10884-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-24 13:18 ` Leon Romanovsky
2018-01-24 15:06 ` Bart Van Assche [this message]
[not found] ` <1516806357.3324.1.camel-Sjgp3cTcYWE@public.gmane.org>
2018-02-05 17:38 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516806357.3324.1.camel@wdc.com \
--to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
--cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hare-IBi9RG/b67k@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).