public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
To: "yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
	<yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
	<pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	"jgg-uk2M96/98Pc@public.gmane.org"
	<jgg-uk2M96/98Pc@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
	<aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] RDMA/vmw_pvrdma: Use standard way to check return value
Date: Wed, 24 Jan 2018 15:07:59 +0000	[thread overview]
Message-ID: <1516806477.3324.2.camel@wdc.com> (raw)
In-Reply-To: <20180124111721.8170-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

On Wed, 2018-01-24 at 13:17 +0200, Yuval Shaia wrote:
> -	if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) == 0) {
> +	if (!pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {

Sorry but I absolutely don't like this change. I think testing a return value
using "== 0" is easier to read than using !.

Bart.

      parent reply	other threads:[~2018-01-24 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 11:17 [PATCH] RDMA/vmw_pvrdma: Use standard way to check return value Yuval Shaia
     [not found] ` <20180124111721.8170-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-24 15:07   ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516806477.3324.2.camel@wdc.com \
    --to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
    --cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox