Re: [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error

Bart Van Assche
2018-01-23T22:59:30Z

On Tue, 2018-01-23 at 14:50 -0800, Paul E. McKenney wrote:
>
> rcu: Fix init_rcu_head() comment.
>
> The current (and implicit) comment header for init_rcu_head() and
> destroy_rcu_head() incorrectly says that they are not needed for
> statically allocated rcu_head structures. This commit therefore
> fixes this comment.
>
> Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 043d04784675..36360d07f25b 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -214,10 +214,12 @@ do { \
> #endif
>
> /*
> - * init_rcu_head_on_stack()/destroy_rcu_head_on_stack() are needed for dynamic
> - * initialization and destruction of rcu_head on the stack. rcu_head structures
> - * allocated dynamically in the heap or defined statically don't need any
> - * initialization.
> + * The init_rcu_head_on_stack() and destroy_rcu_head_on_stack() calls
> + * are needed for dynamic initialization and destruction of rcu_head
> + * on the stack, and init_rcu_head()/destroy_rcu_head() are needed for
> + * dynamic initialization and destruction of statically allocated rcu_head
> + * structures. However, rcu_head structures allocated dynamically in the
> + * heap don't need any initialization.
> */
> #ifdef CONFIG_DEBUG_OBJECTS_RCU_HEAD
> void init_rcu_head(struct rcu_head *head);

Thanks!

Feel free to add:

Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>