Re: [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error

Leon Romanovsky
2018-01-24T06:43:37Z

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

On Tue, Jan 23, 2018 at 10:59:30PM +0000, Bart Van Assche wrote:
> On Tue, 2018-01-23 at 14:50 -0800, Paul E. McKenney wrote:
> >
> > rcu: Fix init_rcu_head() comment.
> >
> > The current (and implicit) comment header for init_rcu_head() and
> > destroy_rcu_head() incorrectly says that they are not needed for
> > statically allocated rcu_head structures. This commit therefore
> > fixes this comment.
> >
> > Reported-by: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
> > Signed-off-by: Paul E. McKenney <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> >
> > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> > index 043d04784675..36360d07f25b 100644
> > --- a/include/linux/rcupdate.h
> > +++ b/include/linux/rcupdate.h
> > @@ -214,10 +214,12 @@ do { \
> > #endif
> >
> > /*
> > - * init_rcu_head_on_stack()/destroy_rcu_head_on_stack() are needed for dynamic
> > - * initialization and destruction of rcu_head on the stack. rcu_head structures
> > - * allocated dynamically in the heap or defined statically don't need any
> > - * initialization.
> > + * The init_rcu_head_on_stack() and destroy_rcu_head_on_stack() calls
> > + * are needed for dynamic initialization and destruction of rcu_head
> > + * on the stack, and init_rcu_head()/destroy_rcu_head() are needed for
> > + * dynamic initialization and destruction of statically allocated rcu_head
> > + * structures. However, rcu_head structures allocated dynamically in the
> > + * heap don't need any initialization.
> > */
> > #ifdef CONFIG_DEBUG_OBJECTS_RCU_HEAD
> > void init_rcu_head(struct rcu_head *head);
>
> Thanks!
>
> Feel free to add:
>
> Reviewed-by: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
>
>

Paul,

Are you going to send it through your tree?

Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]