From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
<yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org"
<sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
"jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org"
<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>,
"pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
<pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
"aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org"
<aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
"hare-IBi9RG/b67k@public.gmane.org"
<hare-IBi9RG/b67k@public.gmane.org>,
"jgg-uk2M96/98Pc@public.gmane.org"
<jgg-uk2M96/98Pc@public.gmane.org>
Subject: Re: [PATCH v2] RDMA: Use standard way to check return value
Date: Mon, 05 Feb 2018 12:38:24 -0500 [thread overview]
Message-ID: <1517852304.3936.75.camel@redhat.com> (raw)
In-Reply-To: <1516806357.3324.1.camel-Sjgp3cTcYWE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Wed, 2018-01-24 at 15:06 +0000, Bart Van Assche wrote:
> On Wed, 2018-01-24 at 14:43 +0200, Yuval Shaia wrote:
> > To be compatible with other modules/drivers, change return code checks
> > from "if (rc != 0)" to "if (rc)".
>
> Sorry but I think this is a completely pointless change. All the code that is
> touched by this patch works fine, conforms to all appropriate coding style
> guides and is easy to read. So why change it?
>
> Bart.
Hi Yuval,
Since about 1/3 of the LOC in this is in srp/srpt, and the maintainer
objects and thinks the patch is unnecessary, I'm inclined to drop this
unless you want to make an argument for why it should go on in.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-05 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 12:43 [PATCH v2] RDMA: Use standard way to check return value Yuval Shaia
[not found] ` <20180124124301.10884-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-24 13:18 ` Leon Romanovsky
2018-01-24 15:06 ` Bart Van Assche
[not found] ` <1516806357.3324.1.camel-Sjgp3cTcYWE@public.gmane.org>
2018-02-05 17:38 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517852304.3936.75.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=hare-IBi9RG/b67k@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).