From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Cc: "hch@lst.de" <hch@lst.de>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
"idanb@mellanox.com" <idanb@mellanox.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH rfc 2/5] irq-am: add some debugfs exposure on tuning state
Date: Thu, 8 Feb 2018 01:24:42 +0000 [thread overview]
Message-ID: <1518053080.2870.93.camel@wdc.com> (raw)
In-Reply-To: <20180205220316.30236-3-sagi@grimberg.me>
On Tue, 2018-02-06 at 00:03 +0200, Sagi Grimberg wrote:
> +static int irq_am_register_debugfs(struct irq_am *am)
> +{
> + char name[20];
> +
> + snprintf(name, sizeof(name), "am%u", am->id);
> + am->debugfs_dir = debugfs_create_dir(name,
> + irq_am_debugfs_root);
How is a user expected to figure out which driver am%u is associated with?
Please make sure that these directories have a name that makes it easy for
users to figure out what driver the moderation settings apply to.
Thanks,
Bart.
next prev parent reply other threads:[~2018-02-08 1:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 22:03 [PATCH rfc 0/5] generic adaptive IRQ moderation library for I/O devices Sagi Grimberg
[not found] ` <20180205220316.30236-1-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-02-05 22:03 ` [PATCH rfc 1/5] irq-am: Introduce library implementing generic adaptive moderation Sagi Grimberg
[not found] ` <20180205220316.30236-2-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-02-06 7:43 ` Or Gerlitz
2018-02-05 22:03 ` [PATCH rfc 2/5] irq-am: add some debugfs exposure on tuning state Sagi Grimberg
2018-02-06 16:04 ` kbuild test robot
2018-02-06 17:38 ` kbuild test robot
2018-02-08 1:24 ` Bart Van Assche [this message]
2018-02-12 19:42 ` Sagi Grimberg
2018-02-05 22:03 ` [PATCH rfc 3/5] irq_poll: wire up irq_am Sagi Grimberg
[not found] ` <20180205220316.30236-4-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-02-08 1:28 ` Bart Van Assche
[not found] ` <1518053304.2870.95.camel-Sjgp3cTcYWE@public.gmane.org>
2018-02-12 19:40 ` Sagi Grimberg
2018-02-05 22:03 ` [PATCH rfc 4/5] IB/cq: add adaptive moderation support Sagi Grimberg
2018-02-06 6:56 ` [PATCH rfc 0/5] generic adaptive IRQ moderation library for I/O devices Or Gerlitz
2018-02-06 9:25 ` Sagi Grimberg
[not found] ` <08889344-db9d-cf46-6cfb-56764042f578-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2018-02-06 11:34 ` Or Gerlitz
2018-02-06 8:54 ` Or Gerlitz
[not found] ` <CAJ3xEMi0KzOMJt7d01ohHW-ZpmdwvfzZCLN0qA-LLFwROeVseQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 9:02 ` Tal Gilboa
2018-02-06 9:34 ` Sagi Grimberg
2018-02-06 9:45 ` Tal Gilboa
[not found] ` <a47a8012-c021-74c4-9161-eaff7374a0b2-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-13 9:30 ` Or Gerlitz
2018-02-13 21:46 ` Tal Gilboa
2018-02-05 22:03 ` [PATCH rfc 5/5] IB/cq: wire up adaptive moderation to workqueue based completion queues Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518053080.2870.93.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=idanb@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=linux-block@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).