From: Doug Ledford <dledford@redhat.com>
To: Shiraz Saleem <shiraz.saleem@intel.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Faisal Latif <faisal.latif@intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Artemy Kovalyov <artemyko@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 40iw: include linux/irq.h
Date: Wed, 14 Mar 2018 16:10:42 -0400 [thread overview]
Message-ID: <1521058242.18703.103.camel@redhat.com> (raw)
In-Reply-To: <20180313132000.GA18400@ssaleem-MOBL4.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
On Tue, 2018-03-13 at 08:20 -0500, Shiraz Saleem wrote:
> On Tue, Mar 13, 2018 at 01:06:20PM +0100, Arnd Bergmann wrote:
> > We get a build failure on ARM unless the header is included explicitly:
> >
> > drivers/infiniband/hw/i40iw/i40iw_verbs.c: In function 'i40iw_get_vector_affinity':
> > drivers/infiniband/hw/i40iw/i40iw_verbs.c:2747:9: error: implicit declaration of function 'irq_get_affinity_mask'; did you mean 'irq_create_affinity_masks'? [-Werror=implicit-function-declaration]
> > return irq_get_affinity_mask(msix_vec->irq);
> > ^~~~~~~~~~~~~~~~~~~~~
> > irq_create_affinity_masks
> > drivers/infiniband/hw/i40iw/i40iw_verbs.c:2747:9: error: returning 'int' from a function with return type 'const struct cpumask *' makes pointer from integer without a cast [-Werror=int-conversion]
> > return irq_get_affinity_mask(msix_vec->irq);
> >
> > Fixes: 7e952b19eb63 ("i40iw: Implement get_vector_affinity API")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> Looks like you beat me to it. 0-day caught this on rdma-nxt and I was going to send the fix today.
>
> Typo in the subject. 40iw --> i40iw. Othwerwise, looks good.
>
> Thanks for the patch, Arnd!
>
> Shiraz
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-03-14 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 12:06 [PATCH] 40iw: include linux/irq.h Arnd Bergmann
2018-03-13 13:20 ` Shiraz Saleem
2018-03-14 20:10 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521058242.18703.103.camel@redhat.com \
--to=dledford@redhat.com \
--cc=arnd@arndb.de \
--cc=artemyko@mellanox.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).