From: Doug Ledford <dledford@redhat.com>
To: Roland Dreier <roland@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org,
Roland Dreier <roland@purestorage.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] RDMA/ucma: Allow resolving address without specifying source address
Date: Thu, 19 Apr 2018 22:09:12 -0400 [thread overview]
Message-ID: <1524190152.11756.13.camel@redhat.com> (raw)
In-Reply-To: <20180419152811.4340-1-roland@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Thu, 2018-04-19 at 08:28 -0700, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> The RDMA CM will select a source device and address by consulting the routing table
> if no source address is passed into rdma_resolve_address(). Userspace will ask for
> this by passing an all-zero source address in the RESOLVE_IP command. Unfortunately
> the new check for non-zero address size rejects this with EINVAL, which breaks valid
> userspace applications.
>
> Fix this by explicitly allowing a zero address family for the source.
>
> Fixes: 2975d5de6428 ("RDMA/ucma: Check AF family prior resolving address")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
Thanks, applied to for-rc.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-20 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 15:28 [PATCH] RDMA/ucma: Allow resolving address without specifying source address Roland Dreier
2018-04-20 2:09 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524190152.11756.13.camel@redhat.com \
--to=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=roland@purestorage.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox