From: Doug Ledford <dledford@redhat.com>
To: Yanjun Zhu <yanjun.zhu@oracle.com>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
monis@mellanox.com, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV
Date: Fri, 27 Apr 2018 14:23:53 -0400 [thread overview]
Message-ID: <1524853433.11756.72.camel@redhat.com> (raw)
In-Reply-To: <f2df9d02-8693-60e6-e4fd-24c81817b898@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Thu, 2018-04-26 at 12:02 +0800, Yanjun Zhu wrote:
> On 2018/4/26 11:52, Jianchao Wang wrote:
> > w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV
> > will not be updated in update_wqe_psn, and the corresponding
> > wqe will not be acked in rxe_completer due to its last_psn is
> > zero. Finally, the other wqe will also not be able to be acked,
> > because the wqe of IB_OPCODE_RC_SEND_ONLY_INV with last_psn 0
> > is still there. This causes large amount of io timeout when
> > nvmeof is over rxe.
> >
> > Add RXE_START_MASK for IB_OPCODE_RC_SEND_ONLY_INV to fix this.
> >
> > Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Thanks, applied to for-rc.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-27 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 3:52 [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV Jianchao Wang
2018-04-26 4:02 ` Yanjun Zhu
2018-04-27 18:23 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524853433.11756.72.camel@redhat.com \
--to=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox