From: Lidong Chen <jemmy858585@gmail.com>
To: dledford@redhat.com, jgg@ziepe.ca, akpm@linux-foundation.org,
qing.huang@oracle.com, leon@kernel.org, artemyko@mellanox.com,
dan.j.williams@intel.com
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
adido@mellanox.com, galsha@mellanox.com, aviadye@mellanox.com,
Lidong Chen <lidongchen@tencent.com>
Subject: [PATCH] IB/umem: use tgid instead of pid in ib_umem structure
Date: Thu, 3 May 2018 22:04:34 +0800 [thread overview]
Message-ID: <1525356274-736-1-git-send-email-lidongchen@tencent.com> (raw)
The userspace may invoke ibv_reg_mr and ibv_dereg_mr by different threads.
If when ibv_dereg_mr invoke and the thread which invoked ibv_reg_mr has
exited, get_pid_task will return NULL, ib_umem_release does not decrease
mm->pinned_vm. This patch fixes it by use tgid.
Signed-off-by: Lidong Chen <lidongchen@tencent.com>
---
drivers/infiniband/core/umem.c | 12 ++++++------
include/rdma/ib_umem.h | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 9a4e899..8813ba5 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -119,7 +119,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
umem->length = size;
umem->address = addr;
umem->page_shift = PAGE_SHIFT;
- umem->pid = get_task_pid(current, PIDTYPE_PID);
+ umem->tgid = get_task_pid(current->group_leader, PIDTYPE_PID);
/*
* We ask for writable memory if any of the following
* access flags are set. "Local write" and "remote write"
@@ -132,7 +132,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
if (access & IB_ACCESS_ON_DEMAND) {
- put_pid(umem->pid);
+ put_pid(umem->tgid);
ret = ib_umem_odp_get(context, umem, access);
if (ret) {
kfree(umem);
@@ -148,7 +148,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
page_list = (struct page **) __get_free_page(GFP_KERNEL);
if (!page_list) {
- put_pid(umem->pid);
+ put_pid(umem->tgid);
kfree(umem);
return ERR_PTR(-ENOMEM);
}
@@ -231,7 +231,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
if (ret < 0) {
if (need_release)
__ib_umem_release(context->device, umem, 0);
- put_pid(umem->pid);
+ put_pid(umem->tgid);
kfree(umem);
} else
current->mm->pinned_vm = locked;
@@ -274,8 +274,8 @@ void ib_umem_release(struct ib_umem *umem)
__ib_umem_release(umem->context->device, umem, 1);
- task = get_pid_task(umem->pid, PIDTYPE_PID);
- put_pid(umem->pid);
+ task = get_pid_task(umem->tgid, PIDTYPE_PID);
+ put_pid(umem->tgid);
if (!task)
goto out;
mm = get_task_mm(task);
diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h
index 23159dd..2398849 100644
--- a/include/rdma/ib_umem.h
+++ b/include/rdma/ib_umem.h
@@ -48,7 +48,7 @@ struct ib_umem {
int writable;
int hugetlb;
struct work_struct work;
- struct pid *pid;
+ struct pid *tgid;
struct mm_struct *mm;
unsigned long diff;
struct ib_umem_odp *odp_data;
--
1.8.3.1
next reply other threads:[~2018-05-03 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 14:04 Lidong Chen [this message]
2018-05-03 15:33 ` [PATCH] IB/umem: use tgid instead of pid in ib_umem structure Jason Gunthorpe
2018-05-03 18:12 ` Leon Romanovsky
2018-05-03 18:26 ` Jason Gunthorpe
2018-05-03 18:43 ` Leon Romanovsky
2018-05-03 22:01 ` Jason Gunthorpe
2018-05-04 8:32 ` 858585 jemmy
2018-05-04 13:39 ` Leon Romanovsky
2018-05-04 15:14 ` lidongchen(陈立东)
2018-05-04 2:41 ` 858585 jemmy
2018-05-04 3:14 ` 858585 jemmy
2018-05-04 8:51 ` 858585 jemmy
2018-05-04 18:23 ` Jason Gunthorpe
2018-05-07 1:38 ` 858585 jemmy
2018-05-08 6:30 ` Jason Gunthorpe
2018-05-08 8:32 ` 858585 jemmy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525356274-736-1-git-send-email-lidongchen@tencent.com \
--to=jemmy858585@gmail.com \
--cc=adido@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=artemyko@mellanox.com \
--cc=aviadye@mellanox.com \
--cc=dan.j.williams@intel.com \
--cc=dledford@redhat.com \
--cc=galsha@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=lidongchen@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=qing.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox