From: Jianxin Xiong <jianxin.xiong@intel.com>
To: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Jianxin Xiong <jianxin.xiong@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Christian Koenig <christian.koenig@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH v10 5/6] dma-buf: Reject attach request from importers that use dma_virt_ops
Date: Tue, 10 Nov 2020 13:41:16 -0800 [thread overview]
Message-ID: <1605044477-51833-6-git-send-email-jianxin.xiong@intel.com> (raw)
In-Reply-To: <1605044477-51833-1-git-send-email-jianxin.xiong@intel.com>
dma_virt_ops is used by virtual devices that map pages / scatterlists to
virtual addresses for CPU access instead of performing DMA. This is not
the intended use of dma_buf_attach() and dma_buf_map_attachment(). CPU
access of dma-buf should use dma_buf_vmap() and related functions.
Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com>
---
drivers/dma-buf/dma-buf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 9a054fb5..ba2b877 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -686,6 +686,11 @@ struct dma_buf_attachment *
if (WARN_ON(importer_ops && !importer_ops->move_notify))
return ERR_PTR(-EINVAL);
+#ifdef CONFIG_DMA_VIRT_OPS
+ if (dev->dma_ops == &dma_virt_ops)
+ return ERR_PTR(-EINVAL);
+#endif
+
attach = kzalloc(sizeof(*attach), GFP_KERNEL);
if (!attach)
return ERR_PTR(-ENOMEM);
--
1.8.3.1
next prev parent reply other threads:[~2020-11-10 21:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 21:41 [PATCH v10 0/6] RDMA: Add dma-buf support Jianxin Xiong
2020-11-10 21:41 ` [PATCH v10 1/6] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong
2020-11-13 0:30 ` Jason Gunthorpe
2020-11-13 3:30 ` Xiong, Jianxin
2020-11-13 12:49 ` Jason Gunthorpe
2020-11-10 21:41 ` [PATCH v10 2/6] RDMA/core: Add device method for registering dma-buf based " Jianxin Xiong
2020-11-10 21:41 ` [PATCH v10 3/6] RDMA/uverbs: Add uverbs command for dma-buf based MR registration Jianxin Xiong
2020-11-13 0:33 ` Jason Gunthorpe
2020-11-13 4:02 ` Xiong, Jianxin
2020-11-10 21:41 ` [PATCH v10 4/6] RDMA/mlx5: Support dma-buf based userspace memory region Jianxin Xiong
2020-11-13 0:39 ` Jason Gunthorpe
2020-11-13 3:51 ` Xiong, Jianxin
2020-11-13 13:06 ` Jason Gunthorpe
2020-11-13 17:28 ` Xiong, Jianxin
2020-11-10 21:41 ` Jianxin Xiong [this message]
2020-11-10 21:41 ` [PATCH v10 6/6] dma-buf: Document that dma-buf size is fixed Jianxin Xiong
2020-11-11 16:33 ` Daniel Vetter
2020-11-12 13:25 ` Jason Gunthorpe
2020-11-13 20:41 ` Daniel Vetter
2020-11-13 0:42 ` [PATCH v10 0/6] RDMA: Add dma-buf support Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605044477-51833-6-git-send-email-jianxin.xiong@intel.com \
--to=jianxin.xiong@intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox