From: Weihang Li <liweihang@huawei.com>
To: <dledford@redhat.com>, <jgg@ziepe.ca>
Cc: <leon@kernel.org>, <linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: [PATCH v3 for-next 05/11] RDMA/hns: WARN_ON if get a reserved sl from users
Date: Thu, 10 Dec 2020 21:22:46 +0800 [thread overview]
Message-ID: <1607606572-11968-6-git-send-email-liweihang@huawei.com> (raw)
In-Reply-To: <1607606572-11968-1-git-send-email-liweihang@huawei.com>
According to the RoCE v1 specification, the sl (service level) 0-7 are
mapped directly to priorities 0-7 respectively, sl 8-15 are reserved. The
driver should verify whether the value of sl is larger than 7, if so, an
exception should be returned.
Signed-off-by: Weihang Li <liweihang@huawei.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 7a0c1ab..b2b8052 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -433,6 +433,10 @@ static int fill_ud_av(struct hns_roce_v2_ud_send_wqe *ud_sq_wqe,
V2_UD_SEND_WQE_BYTE_36_TCLASS_S, ah->av.tclass);
roce_set_field(ud_sq_wqe->byte_40, V2_UD_SEND_WQE_BYTE_40_FLOW_LABEL_M,
V2_UD_SEND_WQE_BYTE_40_FLOW_LABEL_S, ah->av.flowlabel);
+
+ if (WARN_ON(ah->av.sl > MAX_SERVICE_LEVEL))
+ return -EINVAL;
+
roce_set_field(ud_sq_wqe->byte_40, V2_UD_SEND_WQE_BYTE_40_SL_M,
V2_UD_SEND_WQE_BYTE_40_SL_S, ah->av.sl);
--
2.8.1
next prev parent reply other threads:[~2020-12-10 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 13:22 [PATCH v3 for-next 00/11] RDMA/hns: Updates for 5.11 Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 01/11] RDMA/hns: Limit the length of data copied between kernel and userspace Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 02/11] RDMA/hns: Normalization the judgment of some features Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 03/11] RDMA/hns: Do shift on traffic class when using RoCEv2 Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 04/11] RDMA/hns: Avoid filling sl in high 3 bits of vlan_id Weihang Li
2020-12-10 13:22 ` Weihang Li [this message]
2020-12-10 13:22 ` [PATCH v3 for-next 06/11] RDMA/hns: Remove unnecessary access right set during INIT2INIT Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 07/11] RDMA/hns: Fix coding style issues Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 08/11] RDMA/hns: Clear redundant variable initialization Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 09/11] RDMA/hns: Fix incorrect symbol types Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 10/11] RDMA/hns: Fix inaccurate prints Weihang Li
2020-12-10 13:22 ` [PATCH v3 for-next 11/11] RDMA/hns: Simplify AEQE process for different types of queue Weihang Li
2020-12-10 13:35 ` [PATCH v3 for-next 00/11] RDMA/hns: Updates for 5.11 liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1607606572-11968-6-git-send-email-liweihang@huawei.com \
--to=liweihang@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox