From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Natalia Petrova <n.petrova@fintech.ru>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH v2] rdmavt: delete unnecessary NULL check
Date: Tue, 14 Mar 2023 11:26:07 +0200 [thread overview]
Message-ID: <167878596798.47051.3381152453876603271.b4-ty@kernel.org> (raw)
In-Reply-To: <20230303124408.16685-1-n.petrova@fintech.ru>
On Fri, 03 Mar 2023 15:44:08 +0300, Natalia Petrova wrote:
> There is no need to check 'rdi->qp_dev' for NULL. The field 'qp_dev'
> is created in rvt_register_device() which will fail if the 'qp_dev'
> allocation fails in rvt_driver_qp_init(). Overwise this pointer
> doesn't changed and passed to rvt_qp_exit() by the next step.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> [...]
Applied, thanks!
[1/1] rdmavt: delete unnecessary NULL check
https://git.kernel.org/rdma/rdma/c/9b3366ec12f0d7
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2023-03-14 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 14:26 [PATCH] rdmavt: avoid NULL pointer dereference in rvt_qp_exit() Natalia Petrova
2022-10-18 8:41 ` Leon Romanovsky
2022-10-18 14:24 ` Dennis Dalessandro
2023-03-03 12:44 ` [PATCH v2] rdmavt: delete unnecessary NULL check Natalia Petrova
2023-03-14 9:26 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167878596798.47051.3381152453876603271.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=n.petrova@fintech.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox