From: Leon Romanovsky <leon@kernel.org>
To: jgg@ziepe.ca, Yang Li <yang.lee@linux.alibaba.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] RDMA/cma: Remove NULL check before dev_{put, hold}
Date: Mon, 03 Apr 2023 21:24:06 +0300 [thread overview]
Message-ID: <168054624617.6296.18087414911653959045.b4-ty@kernel.org> (raw)
In-Reply-To: <20230331010633.63261-1-yang.lee@linux.alibaba.com>
On Fri, 31 Mar 2023 09:06:33 +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warnings:
>
> ./drivers/infiniband/core/cma.c:713:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
> ./drivers/infiniband/core/cma.c:2433:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> [...]
Applied, thanks!
[1/1] RDMA/cma: Remove NULL check before dev_{put, hold}
https://git.kernel.org/rdma/rdma/c/08ebf57f6e1d73
Best regards,
--
Leon Romanovsky <leon@kernel.org>
next prev parent reply other threads:[~2023-04-03 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 1:06 [PATCH -next] RDMA/cma: Remove NULL check before dev_{put, hold} Yang Li
2023-04-03 18:24 ` Leon Romanovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-14 1:43 Yang Li
2023-06-20 15:51 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168054624617.6296.18087414911653959045.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox