From: Leon Romanovsky <leon@kernel.org>
To: linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
ynachum@amazon.com
Cc: sleybo@amazon.com, matua@amazon.com,
Michael Margolin <mrgolin@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Fix wrong resources deallocation order
Date: Tue, 22 Aug 2023 17:22:31 +0300 [thread overview]
Message-ID: <169271415103.36380.6438440724245904765.b4-ty@kernel.org> (raw)
In-Reply-To: <20230822082725.31719-1-ynachum@amazon.com>
On Tue, 22 Aug 2023 08:27:25 +0000, ynachum@amazon.com wrote:
> When trying to destroy QP or CQ, we first decrease the refcount and
> potentially free memory regions allocated for the object and then
> request the device to destroy the object. If the device fails, the
> object isn't fully destroyed so the user/IB core can try to destroy the
> object again which will lead to underflow when trying to decrease an
> already zeroed refcount.
> Deallocate resources in reverse order of allocating them to safely free
> them.
>
> [...]
Applied, thanks!
[1/1] RDMA/efa: Fix wrong resources deallocation order
https://git.kernel.org/rdma/rdma/c/dc202c57e9a142
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2023-08-22 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 8:27 [PATCH for-next] RDMA/efa: Fix wrong resources deallocation order ynachum
2023-08-22 14:21 ` Leon Romanovsky
2023-08-22 14:22 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169271415103.36380.6438440724245904765.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox