From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Patrick Kelsey <pat.kelsey@cornelisnetworks.com>,
Brendan Cunningham <bcunningham@cornelisnetworks.com>,
Daniel Vacek <neelx@redhat.com>
Cc: stable@vger.kernel.org, Mats Kronberg <kronberg@nsc.liu.se>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] IB/hfi1: Fix sdma.h tx->num_descs off-by-one error (take two)
Date: Sun, 04 Feb 2024 11:40:34 +0200 [thread overview]
Message-ID: <170703963443.16261.7348326025275862840.b4-ty@kernel.org> (raw)
In-Reply-To: <20240201081009.1109442-1-neelx@redhat.com>
On Thu, 01 Feb 2024 09:10:08 +0100, Daniel Vacek wrote:
> Unfortunately the commit `fd8958efe877` introduced another error
> causing the `descs` array to overflow. This reults in further crashes
> easily reproducible by `sendmsg` system call.
>
> [ 1080.836473] general protection fault, probably for non-canonical address 0x400300015528b00a: 0000 [#1] PREEMPT SMP PTI
> [ 1080.869326] RIP: 0010:hfi1_ipoib_build_ib_tx_headers.constprop.0+0xe1/0x2b0 [hfi1]
> --
> [ 1080.974535] Call Trace:
> [ 1080.976990] <TASK>
> [ 1081.021929] hfi1_ipoib_send_dma_common+0x7a/0x2e0 [hfi1]
> [ 1081.027364] hfi1_ipoib_send_dma_list+0x62/0x270 [hfi1]
> [ 1081.032633] hfi1_ipoib_send+0x112/0x300 [hfi1]
> [ 1081.042001] ipoib_start_xmit+0x2a9/0x2d0 [ib_ipoib]
> [ 1081.046978] dev_hard_start_xmit+0xc4/0x210
> --
> [ 1081.148347] __sys_sendmsg+0x59/0xa0
>
> [...]
Applied, thanks!
[1/1] IB/hfi1: Fix sdma.h tx->num_descs off-by-one error (take two)
https://git.kernel.org/rdma/rdma/c/be39e8dcb411fb
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2024-02-04 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 15:21 [PATCH] IB/hfi1: Fix sdma.h tx->num_descs off-by-one error (take two) Daniel Vacek
2024-01-31 12:50 ` Leon Romanovsky
2024-01-31 17:01 ` Dennis Dalessandro
2024-02-01 8:10 ` [PATCH v2] " Daniel Vacek
2024-02-04 9:40 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170703963443.16261.7348326025275862840.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=bcunningham@cornelisnetworks.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=kronberg@nsc.liu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neelx@redhat.com \
--cc=pat.kelsey@cornelisnetworks.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox