From: Selvin Xavier <selvin.xavier@broadcom.com>
To: leon@kernel.org, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com,
kalesh-anakkur.purayil@broadcom.com,
Kashyap Desai <kashyap.desai@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>
Subject: [PATCH for-rc 03/10] RDMA/bnxt_re: Fix incorrect dereference of srq in async event
Date: Tue, 8 Oct 2024 00:41:35 -0700 [thread overview]
Message-ID: <1728373302-19530-4-git-send-email-selvin.xavier@broadcom.com> (raw)
In-Reply-To: <1728373302-19530-1-git-send-email-selvin.xavier@broadcom.com>
From: Kashyap Desai <kashyap.desai@broadcom.com>
Currently driver is not getting correct srq. Dereference only if
qplib has a valid srq.
Fixes: b02fd3f79ec3 ("RDMA/bnxt_re: Report async events and errors")
Reviewed-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
Reviewed-by: Chandramohan Akula <chandramohan.akula@broadcom.com>
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
drivers/infiniband/hw/bnxt_re/main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 686e405..dd39948 100644
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -1028,12 +1028,15 @@ static int bnxt_re_handle_unaffi_async_event(struct creq_func_event
static int bnxt_re_handle_qp_async_event(struct creq_qp_event *qp_event,
struct bnxt_re_qp *qp)
{
- struct bnxt_re_srq *srq = container_of(qp->qplib_qp.srq, struct bnxt_re_srq,
- qplib_srq);
struct creq_qp_error_notification *err_event;
+ struct bnxt_re_srq *srq = NULL;
struct ib_event event = {};
unsigned int flags;
+ if (qp->qplib_qp.srq)
+ srq = container_of(qp->qplib_qp.srq, struct bnxt_re_srq,
+ qplib_srq);
+
if (qp->qplib_qp.state == CMDQ_MODIFY_QP_NEW_STATE_ERR &&
rdma_is_kernel_res(&qp->ib_qp.res)) {
flags = bnxt_re_lock_cqs(qp);
--
2.5.5
next prev parent reply other threads:[~2024-10-08 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 7:41 [PATCH for-rc 00/10] RDMA/bnxt_re: Bug fixes Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 01/10] RDMA/bnxt_re: Fix the max CQ WQEs for older adapters Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 02/10] RDMA/bnxt_re: Fix out of bound check Selvin Xavier
2024-10-08 7:41 ` Selvin Xavier [this message]
2024-10-08 7:41 ` [PATCH for-rc 04/10] RDMA/ bnxt_re: Return more meaningful error Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 05/10] RDMA/bnxt_re: Fix a possible NULL pointer dereference Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 06/10] RDMA/bnxt_re: Avoid CPU lockups due fifo occupancy check loop Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 07/10] RDMA/bnxt_re: Fix an error path in bnxt_re_add_device Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 08/10] RDMA/bnxt_re: Change the sequence of updating the CQ toggle value Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 09/10] RDMA/bnxt_re: Fix a bug while setting up Level-2 PBL pages Selvin Xavier
2024-10-08 7:41 ` [PATCH for-rc 10/10] RDMA/bnxt_re: Fix the GID table length Selvin Xavier
2024-10-11 23:51 ` [PATCH for-rc 00/10] RDMA/bnxt_re: Bug fixes Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1728373302-19530-4-git-send-email-selvin.xavier@broadcom.com \
--to=selvin.xavier@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).