Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>
Cc: Maher Sanalla <msanalla@nvidia.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1] RDMA/uverbs: Propagate errors from rdma_lookup_get_uobject()
Date: Thu, 13 Mar 2025 08:26:57 -0400	[thread overview]
Message-ID: <174186881737.533355.13926406691275120339.b4-ty@kernel.org> (raw)
In-Reply-To: <64f9d3711b183984e939962c2f83383904f97dfb.1740577869.git.leon@kernel.org>


On Wed, 26 Feb 2025 15:54:13 +0200, Leon Romanovsky wrote:
> Currently, the IB uverbs API calls uobj_get_uobj_read(), which in turn
> uses the rdma_lookup_get_uobject() helper to retrieve user objects.
> In case of failure, uobj_get_uobj_read() returns NULL, overriding the
> error code from rdma_lookup_get_uobject(). The IB uverbs API then
> translates this NULL to -EINVAL, masking the actual error and
> complicating debugging. For example, applications calling ibv_modify_qp
> that fails with EBUSY when retrieving the QP uobject will see the
> overridden error code EINVAL instead, masking the actual error.
> 
> [...]

Applied, thanks!

[1/1] RDMA/uverbs: Propagate errors from rdma_lookup_get_uobject()
      https://git.kernel.org/rdma/rdma/c/81f8f7454ad9e0

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>


      parent reply	other threads:[~2025-03-13 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 13:54 [PATCH rdma-next v1] RDMA/uverbs: Propagate errors from rdma_lookup_get_uobject() Leon Romanovsky
2025-02-27 20:57 ` Jason Gunthorpe
2025-02-28 16:42   ` Maher Sanalla
2025-03-13 12:26 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174186881737.533355.13926406691275120339.b4-ty@kernel.org \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=msanalla@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox