From: Leon Romanovsky <leon@kernel.org>
To: Bernard Metzler <bernard.metzler@linux.dev>,
Jason Gunthorpe <jgg@ziepe.ca>,
Geliang Tang <geliang@kernel.org>
Cc: linux-rdma@vger.kernel.org, Geliang Tang <geliang@kernel.org>
Subject: Re: [PATCH] RDMA/siw: drop duplicate check_app_limited in siw_tcp_sendpages
Date: Tue, 29 Sep 2026 14:38:12 -0400 [thread overview]
Message-ID: <179070709246.3974394.9416103585481164471.b4-ty@kernel.org> (raw)
In-Reply-To: <32ef40cc81486adb8f2d43585224ab44d7e77f73.1790234916.git.tanggeliang@kylinos.cn>
On Thu, 24 Sep 2026 15:39:19 +0800, Geliang Tang wrote:
> After do_tcp_sendpages() was converted to use MSG_SPLICE_PAGES and
> later inlined as direct tcp_sendmsg_locked() calls, callers that
> previously needed an explicit tcp_rate_check_app_limited(sk) to cover
> do_tcp_sendpages() no longer need it. tcp_sendmsg_locked() performs the
> check on every path that queues data, making the outer call redundant.
>
> The site changed here, siw_tcp_sendpages() in siw_qp_tx.c, holds the socket
> lock and invokes tcp_sendmsg_locked() on every iteration. The early-return
> paths in tcp_sendmsg_locked() that skip tcp_rate_check_app_limited() - the
> MSG_ZEROCOPY allocation failure and MSG_FASTOPEN branches - return without
> queueing any MSG_SPLICE_PAGES data, so there is no functional consequence
> from omitting the outer check.
>
> [...]
Applied, thanks!
[1/1] RDMA/siw: drop duplicate check_app_limited in siw_tcp_sendpages
https://git.kernel.org/rdma/rdma/c/ad91fd9e9440ab
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2026-09-29 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 7:39 [PATCH] RDMA/siw: drop duplicate check_app_limited in siw_tcp_sendpages Geliang Tang
2026-09-24 7:44 ` sashiko-bot
2026-09-24 14:53 ` Bernard Metzler
2026-09-29 18:38 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179070709246.3974394.9416103585481164471.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=bernard.metzler@linux.dev \
--cc=geliang@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox