From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B0DC2D0DB for ; Thu, 30 Jan 2020 16:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F001D20707 for ; Thu, 30 Jan 2020 16:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727158AbgA3QHW (ORCPT ); Thu, 30 Jan 2020 11:07:22 -0500 Received: from mga03.intel.com ([134.134.136.65]:37360 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbgA3QHW (ORCPT ); Thu, 30 Jan 2020 11:07:22 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 08:07:21 -0800 X-IronPort-AV: E=Sophos;i="5.70,382,1574150400"; d="scan'208";a="222833427" Received: from ddalessa-mobl.amr.corp.intel.com (HELO [10.254.205.187]) ([10.254.205.187]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Jan 2020 08:07:19 -0800 Subject: Re: [PATCH for-next] RDMA/providers: Fix return value when QP type isn't supported To: Leon Romanovsky , Kamal Heib Cc: linux-rdma@vger.kernel.org, Doug Ledford , Jason Gunthorpe References: <20200130082049.463-1-kamalheib1@gmail.com> <20200130083904.GF3326@unreal> From: Dennis Dalessandro Message-ID: <1f508bbc-d858-13b6-d81e-db95fa172e9a@intel.com> Date: Thu, 30 Jan 2020 11:07:17 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200130083904.GF3326@unreal> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 1/30/2020 3:39 AM, Leon Romanovsky wrote: > On Thu, Jan 30, 2020 at 10:20:49AM +0200, Kamal Heib wrote: >> The proper return code is "-EOPNOTSUPP" when the requested QP type is >> not supported by the provider. >> >> Signed-off-by: Kamal Heib >> --- >> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +- >> drivers/infiniband/hw/cxgb4/qp.c | 2 +- >> drivers/infiniband/hw/hns/hns_roce_qp.c | 2 +- >> drivers/infiniband/hw/i40iw/i40iw_verbs.c | 2 +- >> drivers/infiniband/hw/mlx4/qp.c | 2 +- >> drivers/infiniband/hw/mlx5/qp.c | 2 +- >> drivers/infiniband/hw/mthca/mthca_provider.c | 2 +- >> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- >> drivers/infiniband/hw/qedr/verbs.c | 2 +- >> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- >> drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 2 +- >> drivers/infiniband/sw/rdmavt/qp.c | 2 +- >> drivers/infiniband/sw/siw/siw_verbs.c | 2 +- >> 13 files changed, 13 insertions(+), 13 deletions(-) > > *_err() prints definitely should go too. Simple user space > application will create DDOS on dmesg with those prints. > > I would say that other prints should be removed too or at least > put in general way inside the caller of ->create_qp() callback. I'd agree but I don't think that has to be done in this patch. This looks fine to me. -Denny