From: Sasha Khapyorsky <sashak@voltaire.com>
To: Keshetti Mahesh <keshetti.mahesh@gmail.com>
Cc: OFED mailing list <linux-rdma@vger.kernel.org>,
OFED mailing list <general@lists.openfabrics.org>
Subject: [ofa-general] Re: [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X
Date: Sat, 19 Sep 2009 21:08:26 +0300 [thread overview]
Message-ID: <20090919180826.GJ13667@me> (raw)
In-Reply-To: <829ded920909152042y227a709u6e74ee05d6ff05@mail.gmail.com>
On 09:12 Wed 16 Sep , Keshetti Mahesh wrote:
> Fix: Modify ibcheckportwidth to exit if LWS is 1X instead of processing
> next lines.
> Trivial: ibcheckportwidth man page cosmetic change
Again, the patch is malformed. Please verify the patches before
submission.
>
> Signed-off-by: Keshetti Mahesh <keshetti.mahesh@gmail.com>
> ---
> infiniband-diags/man/ibcheckportwidth.8 | 2 +-
> infiniband-diags/scripts/ibcheckportwidth.in | 2 +-
>
> diff --git a/infiniband-diags/man/ibcheckportwidth.8
> b/infiniband-diags/man/ibcheckportwidth.8
> index 85c06fc..c368467 100644
> --- a/infiniband-diags/man/ibcheckportwidth.8
> +++ b/infiniband-diags/man/ibcheckportwidth.8
> @@ -4,7 +4,7 @@
> ibcheckportwidth \- validate IB port for 1x link width
>
> .SH SYNOPSIS
> -.B ibcheckport
> +.B ibcheckportwidth
> [\-h] [\-v] [\-N | \-nocolor] [\-G] [\-C ca_name] [\-P ca_port]
> [\-t(imeout) timeout_ms] <lid|guid> <port>
>
This chunk appears already in the previous patch.
> diff --git a/infiniband-diags/scripts/ibcheckportwidth.in
> b/infiniband-diags/scripts/ibcheckportwidth.in
> index 32c5c5e..60a0892 100644
> --- a/infiniband-diags/scripts/ibcheckportwidth.in
> +++ b/infiniband-diags/scripts/ibcheckportwidth.in
> @@ -103,7 +103,7 @@ function blue(s)
> }
>
> # Only check LinkWidthActive if LinkWidthSupported is not 1X
> -/^LinkWidthSupported/{ if ($2 != "1X") { next } }
> +/^LinkWidthSupported/{ if ($2 == "1X") { exit } }
Applied (by hands). Thanks.
Sasha
> --
> 1.6.4.2
>
> --
> Keshetti Mahesh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-09-19 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 3:42 [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X Keshetti Mahesh
2009-09-19 18:08 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919180826.GJ13667@me \
--to=sashak@voltaire.com \
--cc=general@lists.openfabrics.org \
--cc=keshetti.mahesh@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox