* [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X
@ 2009-09-16 3:42 Keshetti Mahesh
2009-09-19 18:08 ` [ofa-general] " Sasha Khapyorsky
0 siblings, 1 reply; 2+ messages in thread
From: Keshetti Mahesh @ 2009-09-16 3:42 UTC (permalink / raw)
To: Sasha Khapyorsky, OFED mailing list, OFED mailing list,
Hal Rosenstock
Fix: Modify ibcheckportwidth to exit if LWS is 1X instead of processing
next lines.
Trivial: ibcheckportwidth man page cosmetic change
Signed-off-by: Keshetti Mahesh <keshetti.mahesh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
infiniband-diags/man/ibcheckportwidth.8 | 2 +-
infiniband-diags/scripts/ibcheckportwidth.in | 2 +-
diff --git a/infiniband-diags/man/ibcheckportwidth.8
b/infiniband-diags/man/ibcheckportwidth.8
index 85c06fc..c368467 100644
--- a/infiniband-diags/man/ibcheckportwidth.8
+++ b/infiniband-diags/man/ibcheckportwidth.8
@@ -4,7 +4,7 @@
ibcheckportwidth \- validate IB port for 1x link width
.SH SYNOPSIS
-.B ibcheckport
+.B ibcheckportwidth
[\-h] [\-v] [\-N | \-nocolor] [\-G] [\-C ca_name] [\-P ca_port]
[\-t(imeout) timeout_ms] <lid|guid> <port>
diff --git a/infiniband-diags/scripts/ibcheckportwidth.in
b/infiniband-diags/scripts/ibcheckportwidth.in
index 32c5c5e..60a0892 100644
--- a/infiniband-diags/scripts/ibcheckportwidth.in
+++ b/infiniband-diags/scripts/ibcheckportwidth.in
@@ -103,7 +103,7 @@ function blue(s)
}
# Only check LinkWidthActive if LinkWidthSupported is not 1X
-/^LinkWidthSupported/{ if ($2 != "1X") { next } }
+/^LinkWidthSupported/{ if ($2 == "1X") { exit } }
--
1.6.4.2
--
Keshetti Mahesh
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [ofa-general] Re: [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X
2009-09-16 3:42 [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X Keshetti Mahesh
@ 2009-09-19 18:08 ` Sasha Khapyorsky
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Khapyorsky @ 2009-09-19 18:08 UTC (permalink / raw)
To: Keshetti Mahesh; +Cc: OFED mailing list, OFED mailing list
On 09:12 Wed 16 Sep , Keshetti Mahesh wrote:
> Fix: Modify ibcheckportwidth to exit if LWS is 1X instead of processing
> next lines.
> Trivial: ibcheckportwidth man page cosmetic change
Again, the patch is malformed. Please verify the patches before
submission.
>
> Signed-off-by: Keshetti Mahesh <keshetti.mahesh@gmail.com>
> ---
> infiniband-diags/man/ibcheckportwidth.8 | 2 +-
> infiniband-diags/scripts/ibcheckportwidth.in | 2 +-
>
> diff --git a/infiniband-diags/man/ibcheckportwidth.8
> b/infiniband-diags/man/ibcheckportwidth.8
> index 85c06fc..c368467 100644
> --- a/infiniband-diags/man/ibcheckportwidth.8
> +++ b/infiniband-diags/man/ibcheckportwidth.8
> @@ -4,7 +4,7 @@
> ibcheckportwidth \- validate IB port for 1x link width
>
> .SH SYNOPSIS
> -.B ibcheckport
> +.B ibcheckportwidth
> [\-h] [\-v] [\-N | \-nocolor] [\-G] [\-C ca_name] [\-P ca_port]
> [\-t(imeout) timeout_ms] <lid|guid> <port>
>
This chunk appears already in the previous patch.
> diff --git a/infiniband-diags/scripts/ibcheckportwidth.in
> b/infiniband-diags/scripts/ibcheckportwidth.in
> index 32c5c5e..60a0892 100644
> --- a/infiniband-diags/scripts/ibcheckportwidth.in
> +++ b/infiniband-diags/scripts/ibcheckportwidth.in
> @@ -103,7 +103,7 @@ function blue(s)
> }
>
> # Only check LinkWidthActive if LinkWidthSupported is not 1X
> -/^LinkWidthSupported/{ if ($2 != "1X") { next } }
> +/^LinkWidthSupported/{ if ($2 == "1X") { exit } }
Applied (by hands). Thanks.
Sasha
> --
> 1.6.4.2
>
> --
> Keshetti Mahesh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-19 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-16 3:42 [PATCH] 'ibcheckportwidth' : Exit if LWS is 1X Keshetti Mahesh
2009-09-19 18:08 ` [ofa-general] " Sasha Khapyorsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox