[PATCH] osm_subnet.c change void* arithmetic to char*

[PATCH] osm_subnet.c change void* arithmetic to char*

[Smith, Stan]

MS compiler doesn't Grok void* arithmetic, use char*

Signed-off-by: stan smith <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

--- a/opensm/opensm/osm_subnet.c        2009-10-01 12:45:52.000000000 -0700
+++ b/opensm/opensm/osm_subnet.c        2009-10-01 14:24:18.000000000 -0700
@@ -1193,8 +1193,8 @@
                        if (strcmp(r->name, p_key))
                                continue;

-                       p_field1 = (void *)p_opts->file_opts + r->opt_offset;
-                       p_field2 = (void *)p_opts + r->opt_offset;
+                       p_field1 = (char *)p_opts->file_opts + r->opt_offset;
+                       p_field2 = (char *)p_opts + r->opt_offset;
                        /* don't call setup function first time */
                        r->parse_fn(NULL, p_key, p_val, p_field1, p_field2,
                                    NULL);
@@ -1253,8 +1253,8 @@
                        if (!r->can_update || strcmp(r->name, p_key))
                                continue;

-                       p_field1 = (void *)p_opts->file_opts + r->opt_offset;
-                       p_field2 = (void *)p_opts + r->opt_offset;
+                       p_field1 = (char *)p_opts->file_opts + r->opt_offset;
+                       p_field2 = (char *)p_opts + r->opt_offset;
                        r->parse_fn(p_subn, p_key, p_val, p_field1, p_field2,
                                    r->setup_fn);
                        break;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] osm_subnet.c change void* arithmetic to char*

[Jason Gunthorpe]

On Thu, Oct 01, 2009 at 02:38:28PM -0700, Smith, Stan wrote:
> 
> MS compiler doesn't Grok void* arithmetic, use char*

uint8_t* or unsigned char is better practice here, char could be wchar
in some crazy instances..

Probably should build with -Wpointer-arith on Linux.

Regards,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html