From: Sasha Khapyorsky <sashak@voltaire.com>
To: "Smith, Stan" <stan.smith@intel.com>
Cc: "ofw@lists.openfabrics.org" <ofw@lists.openfabrics.org>,
linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] C++ style coding does not compile
Date: Sun, 4 Oct 2009 02:15:30 +0200 [thread overview]
Message-ID: <20091004001530.GL17846@me> (raw)
In-Reply-To: <3F6F638B8D880340AB536D29CD4C1E1912C86E8BA3@orsmsx501.amr.corp.intel.com>
On 16:09 Thu 01 Oct , Smith, Stan wrote:
>
> Move C++ in-stream var declarations to top of {} block as in C style; Var assignments left in place.
> MSFT compiler errors out with Missing ';' before 'type', 'Illegal use of this type osm_prefix_route_t as an expression'?
>
>
> Signed-off-by: stan smith <stan.smith@intel.com>
In this patch whitespace characters are mangled.
Applied by hands. Thanks.
Sasha
>
> diff --git a/opensm/opensm/osm_sa_path_record.c b/opensm/opensm/osm_sa_path_record.c
> index 2247ebe..1166def 100644
> --- a/opensm/opensm/osm_sa_path_record.c
> +++ b/opensm/opensm/osm_sa_path_record.c
> @@ -1214,6 +1214,10 @@ static ib_net16_t pr_rcv_get_end_points(IN osm_sa_t * sa,
> if (!ib_gid_is_multicast(&p_pr->dgid) &&
> ib_gid_get_subnet_prefix(&p_pr->dgid) !=
> sa->p_subn->opt.subnet_prefix) {
> +
> + osm_prefix_route_t *route;
> + osm_prefix_route_t *r;
> +
> OSM_LOG(sa->p_log, OSM_LOG_VERBOSE,
> "Non local DGID subnet prefix 0x%016"
> PRIx64 "\n",
> @@ -1221,11 +1225,9 @@ static ib_net16_t pr_rcv_get_end_points(IN osm_sa_t * sa,
>
> /* Find the router port that is configured to
> handle this prefix, if any */
> - osm_prefix_route_t *route = NULL;
> - osm_prefix_route_t *r = (osm_prefix_route_t *)
> - cl_qlist_head(&sa->p_subn->
> - prefix_routes_list);
> -
> + route = NULL;
> + r = (osm_prefix_route_t *) cl_qlist_head(
> + &sa->p_subn->prefix_routes_list);
> while (r != (osm_prefix_route_t *)
> cl_qlist_end(&sa->p_subn->
> prefix_routes_list)) {
>
next prev parent reply other threads:[~2009-10-04 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 23:09 [PATCH] C++ style coding does not compile Smith, Stan
2009-10-04 0:15 ` Sasha Khapyorsky [this message]
[not found] ` <3F6F638B8D880340AB536D29CD4C1E1912C86E8BA3-osO9UTpF0USkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2009-10-04 0:19 ` [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code Sasha Khapyorsky
2009-10-05 13:43 ` Hal Rosenstock
[not found] ` <f0e08f230910050643j63ce8e81s6d6c9bb35f2fcea5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-12 16:25 ` Sasha Khapyorsky
2009-10-12 16:54 ` [PATCH v2] " Sasha Khapyorsky
2009-10-05 18:38 ` [PATCH] " Rolf Manderscheid
[not found] ` <4ACA3D10.5010909-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2009-10-12 16:49 ` Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091004001530.GL17846@me \
--to=sashak@voltaire.com \
--cc=linux-rdma@vger.kernel.org \
--cc=ofw@lists.openfabrics.org \
--cc=stan.smith@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox