[PATCH] opensm - use uintptr_t instead of unsigned long

[PATCH] opensm - use uintptr_t instead of unsigned long

[Stan C. Smith]

 sizeof unsigned long != sizeof void * in Windows world.

If you can live with uintptr_t for 
  __WORDSIZE == 32 being 'unsigned int' (see stdint.h)
  __WORDSIZE == 64 uintptr_t is 'unsigned long int'
then we could skip the ifdef __GNUC__ and just replace 'unsigned long' with uintptr_t.

Stan.

Signed-off-by: stan smith <stan.smith@intel.com>

diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
index 30cc308..dd7eacc 100644
--- a/opensm/include/opensm/st.h
+++ b/opensm/include/opensm/st.h
@@ -49,7 +49,11 @@
 #endif				/* __cplusplus */
 
 BEGIN_C_DECLS
+#ifdef __GNUC__
 #define st_ptr_t unsigned long
+#else
+#define st_ptr_t uintptr_t
+#endif
 typedef st_ptr_t st_data_t;
 
 #define ST_DATA_T_DEFINED

Re: [PATCH] opensm - use uintptr_t instead of unsigned long

[Jason Gunthorpe]

On Thu, Oct 08, 2009 at 10:12:03AM -0700, Stan C. Smith wrote:

> If you can live with uintptr_t for 
>   __WORDSIZE == 32 being 'unsigned int' (see stdint.h)
>   __WORDSIZE == 64 uintptr_t is 'unsigned long int'
> then we could skip the ifdef __GNUC__ and just replace 'unsigned long' with uintptr_t.

uinptr_t is the appropriate ISO C99 type for this, every platform
should use it.

Non-standard names like st_ptr_t should just be eradicated.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] opensm - use uintptr_t instead of unsigned long

[Stan C. Smith]

 sizeof unsigned long != sizeof void * in Windows world
Use correct type.

Signed-off-by: stan smith <stan.smith@intel.com>

diff --git a/opensm/include/opensm/st.h b/opensm/include/opensm/st.h
index 30cc308..fc558c8 100644
--- a/opensm/include/opensm/st.h
+++ b/opensm/include/opensm/st.h
@@ -49,7 +49,7 @@
 #endif				/* __cplusplus */
 
 BEGIN_C_DECLS
-#define st_ptr_t unsigned long
+#define st_ptr_t uintptr_t
 typedef st_ptr_t st_data_t;
 
 #define ST_DATA_T_DEFINED