From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "Smith,
Stan" <stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Sasha Khapyorsky'
<sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org,
'linux-rdma' <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [ofw] [PATCH] opensm - add OSM_CDECL to qsort compare function definitions
Date: Thu, 8 Oct 2009 11:59:57 -0600 [thread overview]
Message-ID: <20091008175957.GZ5191@obsidianresearch.com> (raw)
In-Reply-To: <7E11A1A23B5A46DB8BB84556E67BF487-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
On Thu, Oct 08, 2009 at 10:10:34AM -0700, Sean Hefty wrote:
> >X86 linkage requires __cdecl attribute on qsort() compare function definition;
> >matches Windows qsort() prototype.
> >Add existing OSM_CDECL to qsort() compare function defintions.
> >OSM_CDECL defined blank for Linux.
>
> ibping also requires the use __cdecl. So far, I've been maintaining
> that patch separately and applying it before updating the winof code
> base. If multiple users of __cdecl are required, maybe we can find
> a common place for the definition.
I don't get it - how can an ISO C conforming compiler require a
non-standard declaration on the function argument to the ISO C
function qsort?
Has the default calling convention been changed for some reason?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-08 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 16:46 [PATCH] opensm - add OSM_CDECL to qsort compare function definitions Stan C. Smith
2009-10-08 17:10 ` Sean Hefty
[not found] ` <7E11A1A23B5A46DB8BB84556E67BF487-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2009-10-08 17:59 ` Jason Gunthorpe [this message]
2009-10-08 18:09 ` Sean Hefty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008175957.GZ5191@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ofw-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
--cc=sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=stan.smith-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox