Re: [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

[Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>]

On 09:43 Mon 05 Oct     , Hal Rosenstock wrote:
> On Sat, Oct 3, 2009 at 8:19 PM, Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
> >
> > Move off subnet destination (router address) resolution code to separate
> > function to improve readability.
> >
> > Signed-off-by: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
> > ---
> >  opensm/opensm/osm_sa_path_record.c |  122 +++++++++++++++--------------------
> >  1 files changed, 52 insertions(+), 70 deletions(-)
> >
> > diff --git a/opensm/opensm/osm_sa_path_record.c b/opensm/opensm/osm_sa_path_record.c
> > index b9c6055..c91c7a2 100644
> > --- a/opensm/opensm/osm_sa_path_record.c
> > +++ b/opensm/opensm/osm_sa_path_record.c
> > @@ -1115,6 +1115,39 @@ Exit:
> >
> >  /**********************************************************************
> >  **********************************************************************/
> > +/* Find the router port that is configured to handle this prefix, if any */
> > +static ib_net64_t find_router(osm_sa_t *sa, ib_net64_t prefix)
> > +{
> > +       osm_prefix_route_t *route = NULL;
> > +       osm_router_t *rtr;
> > +       cl_qlist_t *l = &sa->p_subn->prefix_routes_list;
> > +       cl_list_item_t *i;
> > +
> > +       OSM_LOG(sa->p_log, OSM_LOG_VERBOSE, "Non local DGID subnet prefix "
> > +               "0x%016" PRIx64 "\n", cl_ntoh64(prefix));
> > +
> > +       for (i = cl_qlist_head(l); i != cl_qlist_end(l); i = cl_qlist_next(i)) {
> > +               osm_prefix_route_t *r = (osm_prefix_route_t *)i;
> > +               if (!r->prefix || r->prefix == prefix) {
> > +                       route = r;
> > +                       break;
> > +               }
> > +       }
> > +       if (!route)
> > +               return 0;
> 
> This makes the client error (bad GID) log an error now. Do we want to
> preserve the original behavior ?

I agree that logging verbosity can be reduced to warning level for such
client's error cases.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html