From: Sasha Khapyorsky <sashak@voltaire.com>
To: "Stan C. Smith" <stan.smith@intel.com>
Cc: ofw@lists.openfabrics.org, 'linux-rdma' <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] osmtest - code cleanup
Date: Mon, 12 Oct 2009 23:40:54 +0200 [thread overview]
Message-ID: <20091012214054.GH13830@me> (raw)
In-Reply-To: <4BFF1A3398A74B2AABB948EF2843BF68@amr.corp.intel.com>
On 11:57 Mon 12 Oct , Stan C. Smith wrote:
>
> Remove unused ifdef __WIN__ & redundant include.
>
> Signed-off-by: stan smith <stan.smith@intel.com>
Applied. Thanks. The question is below.
>
> diff --git a/opensm/osmtest/osmtest.c b/opensm/osmtest/osmtest.c
> index c6ec955..82a814e 100644
> --- a/opensm/osmtest/osmtest.c
> +++ b/opensm/osmtest/osmtest.c
> @@ -43,19 +43,13 @@
> *
> */
>
> -#ifdef __WIN__
> -#pragma warning(disable : 4996)
> -#endif
> -
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> -#ifdef __WIN__
> -#include <complib/cl_timer.h>
> -#else
> +#ifndef __WIN__
> #include <strings.h>
> -#include <sys/time.h>
> #endif
I suppose that windows should have string.h, right? Assuming so could we
remove '#ifndef __WIN__' completely here?
Sasha
> +#include <sys/time.h>
> #include <complib/cl_debug.h>
> #include "osmtest.h"
>
>
next prev parent reply other threads:[~2009-10-12 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 18:57 [PATCH] osmtest - code cleanup Stan C. Smith
2009-10-12 21:40 ` Sasha Khapyorsky [this message]
2009-10-12 21:49 ` Smith, Stan
2009-10-12 22:07 ` [PATCH] osmtest/osmtest.c: remove strings.h inclusion Sasha Khapyorsky
2009-10-12 22:25 ` Smith, Stan
2009-10-12 22:15 ` [PATCH] osmtest - code cleanup Sasha Khapyorsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012214054.GH13830@me \
--to=sashak@voltaire.com \
--cc=linux-rdma@vger.kernel.org \
--cc=ofw@lists.openfabrics.org \
--cc=stan.smith@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox