From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Yevgeny Kliteynik
<kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency
Date: Thu, 15 Oct 2009 22:54:53 +0200 [thread overview]
Message-ID: <20091015205453.GH20210@me> (raw)
In-Reply-To: <f0e08f230910151243o12ec4fffv70f6a278667f55e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 15:43 Thu 15 Oct , Hal Rosenstock wrote:
> On Thu, Oct 15, 2009 at 3:26 PM, Sasha Khapyorsky <sashak-smomgflXvObQFizaE/u3fw@public.gmane.orgm> wrote:
> > On 09:36 Thu 15 Oct , Hal Rosenstock wrote:
> >>
> >> Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> ---
> >> diff --git a/opensm/opensm/osm_ucast_cache.c b/opensm/opensm/osm_ucast_cache.c
> >> index 31a5333..8db9df2 100644
> >> --- a/opensm/opensm/osm_ucast_cache.c
> >> +++ b/opensm/opensm/osm_ucast_cache.c
> >> @@ -876,7 +876,7 @@ void osm_ucast_cache_add_link(osm_ucast_mgr_t * p_mgr,
> >> if (osm_node_get_type(p_node_1) != IB_NODE_TYPE_SWITCH &&
> >> osm_node_get_type(p_node_2) != IB_NODE_TYPE_SWITCH) {
> >> OSM_LOG(p_mgr->p_log, OSM_LOG_INFO,
> >> - "Dropping CA-2-CA link - cache invalid\n");
> >> + "Dropping CA/RTR-2-CA/RTR link - cache invalid\n");
> >
> > IMHO it looks more confusing after the change.
>
> It's more accurate and consistent;
This is a log message, not a spec, and 'CA/RTR-2-CA/RTR' as single link
abbreviation looks strange. If you want to make things clearer find a
clear single name or abbreviation for CA/RTR.
> There's another log message which
> says "CA/RTR-2-CA/RTR" rather than "CA-2-CA".
Likely I missed this in those big patch. Would be better to rename back
IMHO.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-15 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 13:36 [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Hal Rosenstock
[not found] ` <20091015133639.GB8041-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-10-15 19:26 ` Sasha Khapyorsky
2009-10-15 19:43 ` Hal Rosenstock
[not found] ` <f0e08f230910151243o12ec4fffv70f6a278667f55e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-15 20:54 ` Sasha Khapyorsky [this message]
2009-10-15 22:00 ` [PATCH] opensm/osm_ucast_cache: reduce OSM_LOG_INFO debug printouts Sasha Khapyorsky
2009-10-15 22:05 ` [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Yevgeny Kliteynik
[not found] ` <4AD79CBC.10606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2009-10-16 12:01 ` Sasha Khapyorsky
2009-10-18 7:29 ` Yevgeny Kliteynik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015205453.GH20210@me \
--to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox