public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Yevgeny Kliteynik
	<kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency
Date: Fri, 16 Oct 2009 14:01:54 +0200	[thread overview]
Message-ID: <20091016120154.GO20210@me> (raw)
In-Reply-To: <4AD79CBC.10606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

On 00:05 Fri 16 Oct     , Yevgeny Kliteynik wrote:
> 
> If I remember it correctly, there's an INFO message
> in the ucast mgr saying something like "switches
> configured for unicast" or "<routing engine name>
> tables configured", or something like that (I don't
> have access to the code right now).

Yes, and there a needs of INFO level is also questionable IMHO.

> So I wanted to see one more line

There are more than one:

$ grep OSM_LOG_INFO opensm/osm_ucast_cache.c | wc -l 
19

> that says that
> cache is not applicable.

We don't need an extra lines, one line instead (as I did in the posted
patch) is enough.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-10-16 12:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 13:36 [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Hal Rosenstock
     [not found] ` <20091015133639.GB8041-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2009-10-15 19:26   ` Sasha Khapyorsky
2009-10-15 19:43     ` Hal Rosenstock
     [not found]       ` <f0e08f230910151243o12ec4fffv70f6a278667f55e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-15 20:54         ` Sasha Khapyorsky
2009-10-15 22:00     ` [PATCH] opensm/osm_ucast_cache: reduce OSM_LOG_INFO debug printouts Sasha Khapyorsky
2009-10-15 22:05     ` [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency Yevgeny Kliteynik
     [not found]       ` <4AD79CBC.10606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2009-10-16 12:01         ` Sasha Khapyorsky [this message]
2009-10-18  7:29           ` Yevgeny Kliteynik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091016120154.GO20210@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org \
    --cc=kliteyn-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox