Re: Multicast joins failing on 1.5-rc1? (OFED BACKPORT BUG)

Jason Gunthorpe
2009-10-21T22:08:37Z

On Wed, Oct 21, 2009 at 04:43:53PM -0500, stuarts wrote:

>> All mcast groups are created in the IP stack using this function:
>>
>> static inline void ip_ib_mc_map(__be32 naddr, const unsigned char
>> *broadcast, char *buf)
>> {
>> [..]
>> buf[8] = broadcast[8]; /* P_Key */
>> buf[9] = broadcast[9];
>> }
>
> And there we have it. I am stuck with the RHEL based kernel. The
> ip_ib_mc_map I have does not even have the broadcast parameter at all
> (naddr and buf only).

Ah, that is what I suspected, OK this makes sense now.

This is a bug in the backport, it is very serious since multicast
does not work as it is.

The code you identified in ipoib_mcast_restart_task is part of
the backport, and is designed to work around the above limitations.

I would remove it, and do the following (untested) instead:

--- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
@@ -814,6 +814,13 @@ void ipoib_mcast_restart_task(struct work_struct *work)
for (mclist = dev->mc_list; mclist; mclist = mclist->next) {
union ib_gid mgid;

+ /* Work around broken ip_ib_mc_map */
+ if (mclist->dmi_addrlen == INFINIBAND_ALEN) {
+ mclist->dmi_addr[5] = 0x10 | (dev->broadcast[5] & 0xF);
+ mclist->dmi_addr[8] = dev->broadcast[8];
+ mclist->dmi_addr[9] = dev->broadcast[9];
+ }
+
if (!ipoib_mcast_addr_is_valid(mclist->dmi_addr,
mclist->dmi_addrlen,
dev->broadcast))

This is better than the current stuff since it preserves the intent of
the ip_ib_mc_map patches, and it adjusts the dmi_addr directly so ip
maddr reports the correct address to aid in debugging.

> Sorry for the extra goop in there. This is gone from the mainline
> kernel, so it is RHEL5.4 + backport that seems to be the problem.

Correct. We need someone to pick up the above patch for the
backports. I don't know who that is (someone please speak up?)

If you can confirm the above does it for you then it would probably
help the backporter.

Jason